From: Zac Medico <zmedico@gentoo.org>
Date: Mon, 8 Dec 2008 03:24:55 +0000 (-0000)
Subject: Bug #250212 - Add a new 'upstream.workaround' qa category, and use it for
X-Git-Tag: v2.2_rc18~44
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=ecefa1d9eb50e9b38d209d2b27d68625c1f8f61d;p=portage.git

Bug #250212 - Add a new 'upstream.workaround' qa category, and use it for
the EMakeParallelDisabled check. Thanks to Mike Auty <ikelos@g.o> for this
patch.

svn path=/main/trunk/; revision=12179
---

diff --git a/bin/repoman b/bin/repoman
index 9dc6ed6c9..fc249250a 100755
--- a/bin/repoman
+++ b/bin/repoman
@@ -314,7 +314,8 @@ qahelp={
 	"virtual.versioned":"PROVIDE contains virtuals with versions",
 	"virtual.exists":"PROVIDE contains existing package names",
 	"virtual.unavailable":"PROVIDE contains a virtual which contains no profile default",
-	"usage.obsolete":"The ebuild makes use of an obsolete construct"
+	"usage.obsolete":"The ebuild makes use of an obsolete construct",
+	"upstream.workaround":"The ebuild works around an upstream bug, an upstream bug should be filed and tracked in bugs.gentoo.org"
 }
 
 qacats = qahelp.keys()
@@ -350,6 +351,7 @@ qawarnings = set((
 "virtual.exists",
 "virtual.unavailable",
 "usage.obsolete",
+"upstream.workaround",
 "LIVEVCS.stable"
 ))
 
diff --git a/man/repoman.1 b/man/repoman.1
index c6d83d5cd..dde0d15d2 100644
--- a/man/repoman.1
+++ b/man/repoman.1
@@ -263,6 +263,10 @@ Bad metadata.xml files
 .B metadata.missing
 Missing metadata.xml files
 .TP
+.B upstream.workaround
+The ebuild works around an upstream bug, an upstream bug should be filed and
+tracked in bugs.gentoo.org
+.TP
 .B usage.obsolete
 The ebuild makes use of an obsolete construct
 .TP
diff --git a/pym/repoman/checks.py b/pym/repoman/checks.py
index c9415b759..c90b54f7b 100644
--- a/pym/repoman/checks.py
+++ b/pym/repoman/checks.py
@@ -291,7 +291,7 @@ class IUseUndefined(LineCheck):
 
 class EMakeParallelDisabled(LineCheck):
 	"""Check for emake -j1 calls which disable parallelization."""
-	repoman_check_name = 'ebuild.minorsyn'
+	repoman_check_name = 'upstream.workaround'
 	re = re.compile(r'^\s*emake\s+-j\s*1\s')
 	error = errors.EMAKE_PARALLEL_DISABLED
 
diff --git a/pym/repoman/errors.py b/pym/repoman/errors.py
index 7c54cc13d..7f45bea21 100644
--- a/pym/repoman/errors.py
+++ b/pym/repoman/errors.py
@@ -13,5 +13,5 @@ MISSING_QUOTES_ERROR = 'Unquoted Variable on line: %d'
 NESTED_DIE_ERROR = 'Ebuild calls die in a subshell on line: %d'
 PATCHES_ERROR = 'PATCHES is not a bash array on line: %d'
 REDUNDANT_CD_S_ERROR = 'Ebuild has redundant cd ${S} statement on line: %d'
-EMAKE_PARALLEL_DISABLED = 'Ebuild calls emake -j1 on line: %d'
+EMAKE_PARALLEL_DISABLED = 'Upstream parallel compilation bug (ebuild calls emake -j1 on line: %d)'
 DEPRECATED_BINDNOW_FLAGS = 'Deprecated bindnow-flags call on line: %d'