From: Mark Walters Date: Sun, 2 Feb 2014 17:40:38 +0000 (+0000) Subject: Re: [PATCH] configure: only install bash completion if supported X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=eb6c4f201d596a973e685bb46d7818b89b341c33;p=notmuch-archives.git Re: [PATCH] configure: only install bash completion if supported --- diff --git a/53/0d2a54d9d68ab9a062de91460761e1c8fa8e0e b/53/0d2a54d9d68ab9a062de91460761e1c8fa8e0e new file mode 100644 index 000000000..963a06b06 --- /dev/null +++ b/53/0d2a54d9d68ab9a062de91460761e1c8fa8e0e @@ -0,0 +1,116 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 2080D431FBD + for ; Sun, 2 Feb 2014 09:43:16 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id jWQIeXdHS31S for ; + Sun, 2 Feb 2014 09:43:08 -0800 (PST) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id D846B431FBC + for ; Sun, 2 Feb 2014 09:43:07 -0800 (PST) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1WA14O-0001NQ-CG; Sun, 02 Feb 2014 17:43:02 +0000 +Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) + (envelope-from ) + id 1WA13U-0007dP-Vh; Sun, 02 Feb 2014 17:42:05 +0000 +From: Mark Walters +To: Jani Nikula , notmuch@notmuchmail.org +Subject: Re: [PATCH] configure: only install bash completion if supported +In-Reply-To: <1391359677-12497-1-git-send-email-jani@nikula.org> +References: <1391359677-12497-1-git-send-email-jani@nikula.org> +User-Agent: Notmuch/0.15.2+484~gfb59956 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Sun, 02 Feb 2014 17:40:38 +0000 +Message-ID: <877g9dqup5.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 93.97.24.31 +X-QM-Geographic: According to ripencc, + this message was delivered by a machine in Britain (UK) (GB). +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: bc4a3a4d2c7913277a1edf16efa1e1a5 (of first 20000 bytes) +X-SpamAssassin-Score: 0.0 +X-SpamAssassin-SpamBar: / +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored 0.0 points. Summary of the scoring: + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * 0.0 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 02 Feb 2014 17:43:16 -0000 + + +This LGTM (untested) + +I think this is the right way to do this: I don't think we should +spam a user with error messages for attempting tab completion with +an older version of bash-completion (which I think you said was the case +with the other version) + +Best wishes + +Mark + + +On Sun, 02 Feb 2014, Jani Nikula wrote: +> Our bash completion depends on bash-completion 1.90 or later. Only +> install where available. +> --- +> configure | 8 ++++++++ +> 1 file changed, 8 insertions(+) +> +> diff --git a/configure b/configure +> index 13b6062..66aaedb 100755 +> --- a/configure +> +++ b/configure +> @@ -360,6 +360,14 @@ else +> have_valgrind=0 +> fi +> +> +printf "Checking for bash-completion (>= 1.90)... " +> +if pkg-config --atleast-version=1.90 bash-completion; then +> + printf "Yes.\n" +> +else +> + printf "No (will not install bash completion).\n" +> + WITH_BASH=0 +> +fi +> + +> if [ -z "${EMACSLISPDIR}" ]; then +> if pkg-config --exists emacs; then +> EMACSLISPDIR=$(pkg-config emacs --variable sitepkglispdir) +> -- +> 1.8.5.2 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch