From: Tomi Ollila Date: Sat, 3 Jan 2015 13:49:36 +0000 (+0200) Subject: Re: [PATCH 2/2] completion: generate notmuch-completion.zsh using doc/conf.py X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=eab19f1307992ede9313b652508b05179fac3dee;p=notmuch-archives.git Re: [PATCH 2/2] completion: generate notmuch-completion.zsh using doc/conf.py --- diff --git a/3f/d8db97eb5a4d3e87f3d9970316025818c91105 b/3f/d8db97eb5a4d3e87f3d9970316025818c91105 new file mode 100644 index 000000000..9633fd21f --- /dev/null +++ b/3f/d8db97eb5a4d3e87f3d9970316025818c91105 @@ -0,0 +1,84 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 71591431FBC + for ; Sat, 3 Jan 2015 05:50:12 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 72ymR+f5hKIF for ; + Sat, 3 Jan 2015 05:50:09 -0800 (PST) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 24C7A431FB6 + for ; Sat, 3 Jan 2015 05:50:09 -0800 (PST) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 591D5100051; + Sat, 3 Jan 2015 15:49:37 +0200 (EET) +From: Tomi Ollila +To: David Bremner , notmuch@notmuchmail.org +Subject: Re: [PATCH 2/2] completion: generate notmuch-completion.zsh + using doc/conf.py +In-Reply-To: <87387sxaa7.fsf@maritornes.cs.unb.ca> +References: <1420289900-29717-1-git-send-email-david@tethera.net> + <1420289900-29717-2-git-send-email-david@tethera.net> + <87387sxaa7.fsf@maritornes.cs.unb.ca> +User-Agent: Notmuch/0.19+14~ge04617b (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 03 Jan 2015 13:50:12 -0000 + +On Sat, Jan 03 2015, David Bremner wrote: + +> David Bremner writes: +> +>> I noticed that the (out of date) list of subcommands was simply +>> repeating the summary lines from the manpage. Since those summary +>> lines are already kept in machine readable form in doc/conf.py, +>> it's easy to compute that part of the completion file. +> +> I meant to annotate this, but lost a fight with git-send-email. I'm not +> sure if the change to notmuch-completions.zsh is worth the trouble (how +> often will we add subcommands?), but the configuration change should +> probably go in anyway, at least one person already mentioned this in a +> bug report. + +I agree that 2/2 may be left out (I rather skip checking it for now ;) + +The changes in 1/2 looks good, but you could have included the new python +definition in line ~454 in (new) configure, which originally is: + + if hash sphinx-build > /dev/null 2>&1 && python -m sphinx.writers.manpage >/dev/null 2>&1 ; then + +(actually, this could be like: + + if command -v sphinx-build >/dev/null && "$python" -m sphinx.writers.manpage >/dev/null 2>&1 ; then + + (add that 2>&1 to be consistent with other code, I did not include it + as I think it is wrong to do so ;)) + + +Tomi