From: Zac Medico <zmedico@gentoo.org>
Date: Tue, 23 Oct 2007 00:32:07 +0000 (-0000)
Subject: Bug #196652 - Check for useless ABOUT-NLS|COPYING|LICENSE
X-Git-Tag: v2.1.3.16~4
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=ea6f9ff838c257fb22a12c686f04b3b69dbbd0fd;p=portage.git

Bug #196652 - Check for useless ABOUT-NLS|COPYING|LICENSE
files in dodoc arguments. (trunk r8236)

svn path=/main/branches/2.1.2/; revision=8237
---

diff --git a/bin/repoman b/bin/repoman
index 938f3b6c3..9579903c5 100755
--- a/bin/repoman
+++ b/bin/repoman
@@ -817,6 +817,25 @@ class EbuildQuote(object):
 				break
 		return errors
 
+class EbuildUselessDodoc(object):
+	"""Check ebuild for useless files in dodoc arguments."""
+	repoman_check_name = 'ebuild.minorsyn'
+	uselessdodoc_re = re.compile(
+		r'^\s*dodoc(\s+|\s+.*\s+)(ABOUT-NLS|COPYING|LICENSE)($|\s)')
+
+	def __init__(self, contents):
+		self.contents = contents
+
+	def Run(self):
+		errors = []
+		uselessdodoc_re = self.uselessdodoc_re
+		for num, line in enumerate(self.contents):
+			match = uselessdodoc_re.match(line)
+			if match:
+				errors.append((num + 1, "Useless dodoc '%s'" % \
+					(match.group(2), ) + " on line: %d"))
+		return errors
+
 if mymode == "commit":
 	retval = ("","")
 	if isCvs:
@@ -1438,7 +1457,7 @@ for x in scanlist:
 		finally:
 			f.close()
 			del f
-		for check in (EbuildQuote, ):
+		for check in (EbuildQuote, EbuildUselessDodoc):
 			c = check(contents)
 			errors = c.Run()
 			for e in errors: