From: Mark Walters Date: Sun, 26 Jan 2014 19:37:27 +0000 (+0000) Subject: Re: [PATCH] emacs: initialize ido mode in notmuch-mua.el X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=e9718bcb4f4c8c4497c789634d0469b40ecfad85;p=notmuch-archives.git Re: [PATCH] emacs: initialize ido mode in notmuch-mua.el --- diff --git a/99/a7bfa55c2b67b09a1724cc72ce7777ef162e96 b/99/a7bfa55c2b67b09a1724cc72ce7777ef162e96 new file mode 100644 index 000000000..561e6286b --- /dev/null +++ b/99/a7bfa55c2b67b09a1724cc72ce7777ef162e96 @@ -0,0 +1,110 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 489FD431FBD + for ; Sun, 26 Jan 2014 11:40:10 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id xEaCaWpCMIBe for ; + Sun, 26 Jan 2014 11:40:05 -0800 (PST) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id E008F431FBC + for ; Sun, 26 Jan 2014 11:40:04 -0800 (PST) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1W7VYb-0006LD-K0; Sun, 26 Jan 2014 19:40:02 +0000 +Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) + (envelope-from ) + id 1W7VXi-0001zj-9m; Sun, 26 Jan 2014 19:38:54 +0000 +From: Mark Walters +To: David Bremner , notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: initialize ido mode in notmuch-mua.el +In-Reply-To: <87bnyzoqq9.fsf@zancas.localnet> +References: <87y5sipcjn.fsf@qmul.ac.uk> + <1329900529-16295-1-git-send-email-markwalters1009@gmail.com> + <87bnyzoqq9.fsf@zancas.localnet> +User-Agent: Notmuch/0.15.2+484~gfb59956 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Sun, 26 Jan 2014 19:37:27 +0000 +Message-ID: <8738kaa614.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 93.97.24.31 +X-QM-Geographic: According to ripencc, + this message was delivered by a machine in Britain (UK) (GB). +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 3e56a99d089b22c434adc8aa9d4d0bf0 (of first 20000 bytes) +X-SpamAssassin-Score: 0.0 +X-SpamAssassin-SpamBar: / +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored 0.0 points. Summary of the scoring: + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * 0.0 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 26 Jan 2014 19:40:10 -0000 + + +I don't have anything older than 23.4 anymore so I am afraid I can't +test. My recollection is that I upgraded to 23.4 the problem went away +so I forgot about it. + +(I couldn't see easily what version of emacs debian stable has now as +seemed to be called 45.) + +Best wishes + +Mark + + +On Sat, 25 Jan 2014, David Bremner wrote: +> Mark Walters writes: +> +>> ido-completing-read is used in notmuch-mua.el without any +>> initialization. This should work but a bug (emacs bug #3247) in some +>> emacs 23 versions (including 23.2.1 from Debian stable) causes emacs +>> to get stuck in the mini-buffer. This tests to see if ido-mode has +>> been initialized and if not calls it. This avoids the bug for these +>> older versions of emacs. +>> +>> This is the only place that ido-completing-read is used so an alternative +>> would be to replace ido-completing-read by completing-read but cworth +>> expressed a preference for the ido version in +>> id:"87wrhfvk6a.fsf@yoom.home.cworth. +> +> This patch was tagged wip, but then there was no progress ;). It still +> applies cleanly, and doesn't seem to do any harm in emacs 23.4 nor +> emacs24.3. I don't have 23.2 at hand but I guess Tomi or Mark can +> confirm it actually fixes the bug there. +> +> I propose we either apply the patch or ::wontfix the bug. +> +> cheers, +> +> d