From: Jeffrey Altman <jaltman@secure-endpoints.com>
Date: Thu, 21 Sep 2006 02:43:12 +0000 (+0000)
Subject: windows thread support frees thread local storage after TlsSetValue
X-Git-Tag: krb5-1.6-alpha1~131
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=e83127dee8e6994904b85f7b8b3a30b6238fec7c;p=krb5.git

windows thread support frees thread local storage after TlsSetValue

 	threads.c: The return value of TlsSetValue is non-zero on
                   success.  As a result of misinterpreting the
                   return value, the memory set in TLS is then freed.
		   A subsequent call to TlsGetValue returns the
		   invalid pointer.

ticket: new
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18600 dc483132-0cff-0310-8789-dd5450dbe970
---

diff --git a/src/util/support/threads.c b/src/util/support/threads.c
index ebc1dafae..7693cbb53 100644
--- a/src/util/support/threads.c
+++ b/src/util/support/threads.c
@@ -275,9 +275,9 @@ int k5_setspecific (k5_key_t keynum, void *value)
 	/* add to global linked list */
 	/*	t->next = 0; */
 	err = TlsSetValue(tls_idx, t);
-	if (err) {
+	if (!err) {
 	    free(t);
-	    return err;
+	    return GetLastError();
 	}
     }