From: Jeff King Date: Mon, 19 Sep 2011 19:15:45 +0000 (-0400) Subject: t4014: clean up format.thread config after each test X-Git-Tag: v1.7.7-rc3~4^2 X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=e810715528eda01914d2df82628872e8df9929d5;p=git.git t4014: clean up format.thread config after each test The threading tests turn on format.thread, but never clean up after themselves, meaning that later tests will also have format.thread set. This is more annoying than most leftover config, too, because not only does it impact the results of other tests, but it does so non-deterministically. Threading requires the generation of message-ids, which incorporate the current time, meaning a slow-running test script may generate different results from run to run. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh index 15bd4a648..070041f7a 100755 --- a/t/t4014-format-patch.sh +++ b/t/t4014-format-patch.sh @@ -445,22 +445,22 @@ test_expect_success 'thread deep cover-letter in-reply-to' ' ' test_expect_success 'thread via config' ' - git config format.thread true && + test_config format.thread true && check_threading expect.thread master ' test_expect_success 'thread deep via config' ' - git config format.thread deep && + test_config format.thread deep && check_threading expect.deep master ' test_expect_success 'thread config + override' ' - git config format.thread deep && + test_config format.thread deep && check_threading expect.thread --thread master ' test_expect_success 'thread config + --no-thread' ' - git config format.thread deep && + test_config format.thread deep && check_threading expect.no-threading --no-thread master '