From: Jani Nikula Date: Mon, 29 Sep 2014 17:28:26 +0000 (+0300) Subject: Re: [PATCH 1/5] cli: Refactor option passing in the search command X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=e796bb34f572a1e15eb1305fbc098c7c957600a7;p=notmuch-archives.git Re: [PATCH 1/5] cli: Refactor option passing in the search command --- diff --git a/4e/7a8e5184b78714477d9f0d89a5220c1301a3f8 b/4e/7a8e5184b78714477d9f0d89a5220c1301a3f8 new file mode 100644 index 000000000..89d21140b --- /dev/null +++ b/4e/7a8e5184b78714477d9f0d89a5220c1301a3f8 @@ -0,0 +1,87 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 11A6F431FCF + for ; Mon, 29 Sep 2014 10:28:44 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id NZDZEZm7LkeW for ; + Mon, 29 Sep 2014 10:28:36 -0700 (PDT) +Received: from mail-wg0-f49.google.com (mail-wg0-f49.google.com + [74.125.82.49]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client + certificate requested) by olra.theworths.org (Postfix) with ESMTPS id + 89CD4431FD4 for ; Mon, 29 Sep 2014 10:28:31 -0700 + (PDT) +Received: by mail-wg0-f49.google.com with SMTP id x12so895719wgg.20 + for ; Mon, 29 Sep 2014 10:28:29 -0700 (PDT) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:from:to:subject:in-reply-to:references + :user-agent:date:message-id:mime-version:content-type; + bh=k5MpagCpAscibIZuRMzWeDcNsJGyBud/hvC1mND+TU8=; + b=C9/3diJI/KdhPB3jd+2c69gw+jXad0G1Cv1aEK58TvECXgrMMmY+a3Jj30yr6qenr6 + vDnT+swHDdQZUUu8zShYXUrFr+iB4EfEZL94CexuPc4tkLqFL/tCzBP86H+KCREeUvaU + 3p29CBiXMIpo7VYUqdKTWBzJWmGGUKdSqfCWocT8AnXlLFlOdIiAvDvqfyxQQJl/D6lY + aHz3HzGvLkLbUcLa05M5a5I8yRVxVB2n0CFGE2cvNQZySEsZUfjP4WTQm5lFIZyJx14w + RsoKfa1x6ZrvRlbzAWJPao/Xm83e32vr+IGrJkX7KE9JPOhmKic6SYUFs6qfRRA4IzCU + Vx+g== +X-Gm-Message-State: + ALoCoQlLVNf+wlae3sdLxKeD1U9HCiIGnxvcaf2sYdwGB+PtxA3RnKpWd9m983iFIDesCKCU7lZk +X-Received: by 10.180.81.195 with SMTP id c3mr38753895wiy.11.1412011709328; + Mon, 29 Sep 2014 10:28:29 -0700 (PDT) +Received: from localhost (dsl-hkibrasgw2-58c36c-245.dhcp.inet.fi. + [88.195.108.245]) by mx.google.com with ESMTPSA id + bt9sm16374207wjc.44.2014.09.29.10.28.28 for + (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Mon, 29 Sep 2014 10:28:28 -0700 (PDT) +From: Jani Nikula +To: Michal Sojka , Tomi Ollila , + notmuch@notmuchmail.org +Subject: Re: [PATCH 1/5] cli: Refactor option passing in the search command +In-Reply-To: <87k34rtoi2.fsf@steelpick.2x.cz> +References: <1411378679-7307-1-git-send-email-sojkam1@fel.cvut.cz> + <1411378679-7307-2-git-send-email-sojkam1@fel.cvut.cz> + + <87k34rtoi2.fsf@steelpick.2x.cz> +User-Agent: Notmuch/0.18.1+65~g9f0f30f (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Mon, 29 Sep 2014 20:28:26 +0300 +Message-ID: <874mvqxrnp.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 29 Sep 2014 17:28:44 -0000 + +On Thu, 25 Sep 2014, Michal Sojka wrote: +> On Thu, Sep 25 2014, Tomi Ollila wrote: +>> Although the test and the implementation in the next patches look OK, I'd +>> prefer the FLAG implementation Jani suggested earlier. IMO now that I +>> compare these two it looks cleaner and simpler... +> +> The question is which kind of simplicity you have in mind. I think that +> my version is simpler to type (less keystrokes). But if others have +> different opinion, I don't mind. + +I'm biased, but I do like the implementation simplicity of my +approach. Adding the bash completion support is also trivial. + +BR, +Jani.