From: Jani Nikula Date: Tue, 3 Sep 2013 12:11:12 +0000 (+0200) Subject: Re: [PATCH 1/2] test: add more maildir flag syncing related tests to insert X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=e788ad101e5298045ada00604f73baa77d767752;p=notmuch-archives.git Re: [PATCH 1/2] test: add more maildir flag syncing related tests to insert --- diff --git a/ed/61e11dae93dc2fc1b8a6f615a14dd29bacf146 b/ed/61e11dae93dc2fc1b8a6f615a14dd29bacf146 new file mode 100644 index 000000000..493e91471 --- /dev/null +++ b/ed/61e11dae93dc2fc1b8a6f615a14dd29bacf146 @@ -0,0 +1,113 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 62E85431FDA + for ; Tue, 3 Sep 2013 05:11:35 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id EPZ8G-PT8QGE for ; + Tue, 3 Sep 2013 05:11:29 -0700 (PDT) +Received: from mail-ee0-f48.google.com (mail-ee0-f48.google.com + [74.125.83.48]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client + certificate requested) by olra.theworths.org (Postfix) with ESMTPS id + 1DD79431FD8 for ; Tue, 3 Sep 2013 05:11:29 -0700 + (PDT) +Received: by mail-ee0-f48.google.com with SMTP id l10so2899566eei.7 + for ; Tue, 03 Sep 2013 05:11:28 -0700 (PDT) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:from:to:subject:in-reply-to:references + :user-agent:date:message-id:mime-version:content-type; + bh=Mn3UVdTPholh6ZevzRrezhUf+/b54sjia4MaWB6Wii8=; + b=Y4MQf5t73pdSSF04qwOgwxzZeLl7cm53VuN7T83qXHNz+VMRPoM/ET51RJXgCFj0pj + RfQ6e/+pNpAQB5/RVl2xJxnAI4U3h5dcPZqIzrxNRP1D7pW16ZzDmWHA1+dQ9jQwDlKu + EsaRAdr6XuxP/3lldZd4TCxAxK7APE5cN7xeAOqXVKvoq7+im4n+3po5OV+fXx3wL6+X + GMcAgsuSqXa/C0B1VNfIsKUj/poE2rhZXClfgZdFuy1MwyZt9cX3RpHMniTTApxQF6kC + lKopGVTm/pnAqW53EJNrtjVsIqSRHtsqyKHqsnsCQ7/+keFkCWqPRuMFSPV+bSWK+Oon + zncw== +X-Gm-Message-State: + ALoCoQmKHPD6g6BdFIsSL779BimHW5ArypeJBk/tcdof9JWgabNA/0X2nfvqbgsFHyuFyLTl+WPR +X-Received: by 10.14.175.2 with SMTP id y2mr435686eel.83.1378210286595; + Tue, 03 Sep 2013 05:11:26 -0700 (PDT) +Received: from localhost ([2001:4b98:dc0:43:216:3eff:fe1b:25f3]) + by mx.google.com with ESMTPSA id h52sm31018870eez.3.1969.12.31.16.00.00 + (version=TLSv1.1 cipher=RC4-SHA bits=128/128); + Tue, 03 Sep 2013 05:11:24 -0700 (PDT) +From: Jani Nikula +To: David Bremner , notmuch@notmuchmail.org +Subject: Re: [PATCH 1/2] test: add more maildir flag syncing related tests to + insert +In-Reply-To: <87mwnus1bg.fsf@zancas.localnet> +References: <1378170613-3584-1-git-send-email-david@tethera.net> + <1378185543-25271-1-git-send-email-jani@nikula.org> + <87mwnus1bg.fsf@zancas.localnet> +User-Agent: Notmuch/0.15.2+177~gb1ba76c (http://notmuchmail.org) Emacs/23.2.1 + (x86_64-pc-linux-gnu) +Date: Tue, 03 Sep 2013 14:11:12 +0200 +Message-ID: <87fvtmds0v.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 03 Sep 2013 12:11:35 -0000 + +On Tue, 03 Sep 2013, David Bremner wrote: +> Jani Nikula writes: +>> +>> +test_begin_subtest "Insert message with default tags stays in new/" +>> +gen_insert_msg +>> +notmuch insert < "$gen_msg_filename" +>> +output=$(notmuch search --output=files id:$gen_msg_id) +>> +dirname=$(dirname "$output") +>> +test_expect_equal "$dirname" "$MAIL_DIR/new" +> +> I'm not sure if this is a bug or a feature, but this enforces a +> constraint on the default tags that notmuch ships enabled. Is that what +> we want, or would it be better to set unread explicitely here? + +We already pretty heavily depend on those default tags, so I'd say just +leave it like this. If we want to fix it later, there's some other +fixing to do too. Try this patch and 'make test': + +diff --git a/notmuch-config.c b/notmuch-config.c +index 6845e3c..8362c13 100644 +--- a/notmuch-config.c ++++ b/notmuch-config.c +@@ -365,8 +365,8 @@ notmuch_config_open (void *ctx, + } + + if (notmuch_config_get_new_tags (config, &tmp) == NULL) { +- const char *tags[] = { "unread", "inbox" }; +- notmuch_config_set_new_tags (config, tags, 2); ++ const char *tags[] = { "flagged" }; ++ notmuch_config_set_new_tags (config, tags, 1); + } + + if (notmuch_config_get_new_ignore (config, &tmp) == NULL) { + +I get: + +Notmuch test suite complete. +396/579 tests passed. +183 tests failed. + + +BR, +Jani.