From: Paul Mackerras <paulus@samba.org>
Date: Tue, 15 Jan 2008 11:30:40 +0000 (+1100)
Subject: gitk: Fix bug where editing an existing view would cause an infinite loop
X-Git-Tag: v1.5.6-rc0~20^2~22
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=e7297a1c5fd1133134e78a775e8b87d7679fb526;p=git.git

gitk: Fix bug where editing an existing view would cause an infinite loop

This fixes a bug where changing the commit range or file list for an
existing view and then clicking OK would cause gitk to go into an
infinite loop.  The problem was that newviewok was invoking reloadcommits
via "run reloadcommits", but reloadcommits wasn't explicitly returning
0, and whatever it was returning was causing dorunq to run it over
and over again.  This fixes it by making reloadcommits return 0.

Signed-off-by: Paul Mackerras <paulus@samba.org>
---

diff --git a/gitk b/gitk
index c707c3c10..322ac93f8 100755
--- a/gitk
+++ b/gitk
@@ -263,6 +263,7 @@ proc reloadcommits {} {
     catch {unset targetid}
     setcanvscroll
     getcommits
+    return 0
 }
 
 # This makes a string representation of a positive integer which