From: Mark Walters Date: Mon, 26 Aug 2013 21:09:02 +0000 (+0100) Subject: [Patch v2 0/3] contrib: pick: remove an unused variable X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=e64b4f975f0b0af85cfa764007db7c8ecaabcb3b;p=notmuch-archives.git [Patch v2 0/3] contrib: pick: remove an unused variable --- diff --git a/e4/30c0753536015e956a2ccdba8041d3fb979082 b/e4/30c0753536015e956a2ccdba8041d3fb979082 new file mode 100644 index 000000000..8e06d51ef --- /dev/null +++ b/e4/30c0753536015e956a2ccdba8041d3fb979082 @@ -0,0 +1,92 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 75809431FD8 + for ; Mon, 26 Aug 2013 14:09:21 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 2.7 +X-Spam-Level: ** +X-Spam-Status: No, score=2.7 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001, + FREEMAIL_REPLY=2.499, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 8LYEHUzt3T+v for ; + Mon, 26 Aug 2013 14:09:15 -0700 (PDT) +Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com + [209.85.212.175]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id B6BA6431FAF + for ; Mon, 26 Aug 2013 14:09:14 -0700 (PDT) +Received: by mail-wi0-f175.google.com with SMTP id cb5so2244554wib.2 + for ; Mon, 26 Aug 2013 14:09:13 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:cc:subject:date:message-id; + bh=s6hmIBu7MlzQXxO34mhN5j4XroADwB93ubO2rcxc81M=; + b=1JaO/KAlTwJklAU2ogAdBTqrwa98K58NqR32dzzBWkfFVUSWSIgq7jyasID4I5YqC/ + tlr8jMRKCdHq9Fu1q9t3wKMSeh/DkvbvYDBq0VaPCK7+6cL4uFuXOH+jixTzLE2bGLwn + iUlzh6vEuLarIeoQHQ/v7VYgyQEeVR2GixgPYC0pr581AJhdx9hPIAQzSeEAWWYS+Wyt + DLpxZ05hFu9btu7i7l3QA7Ywij4pRY4mSOcau0GrIGSRhwhGiDDzCYqtedBx8MZwusJd + avnFSKOYwxeCyLSz4i4iFY7q+l/Wc37v4Gk66HNstTFb6YnuOcWOpM+WBAxqWYm/Zcy7 + mMtg== +X-Received: by 10.180.188.203 with SMTP id gc11mr8882214wic.7.1377551352231; + Mon, 26 Aug 2013 14:09:12 -0700 (PDT) +Received: from localhost (93-97-24-31.zone5.bethere.co.uk. [93.97.24.31]) + by mx.google.com with ESMTPSA id mw9sm10441625wic.4.1969.12.31.16.00.00 + (version=TLSv1.2 cipher=RC4-SHA bits=128/128); + Mon, 26 Aug 2013 14:09:11 -0700 (PDT) +From: Mark Walters +To: notmuch@notmuchmail.org +Subject: [Patch v2 0/3] contrib: pick: remove an unused variable +Date: Mon, 26 Aug 2013 22:09:02 +0100 +Message-Id: <1377551345-27147-1-git-send-email-markwalters1009@gmail.com> +X-Mailer: git-send-email 1.7.9.1 +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 26 Aug 2013 21:09:21 -0000 + +v2 of this series is at +id:1377460214-4795-1-git-send-email-markwalters1009@gmail.com + +v2 had a bug on refresh view (which I should have tested more). The +main pick view only worked by fluke as the initial call to pick-worker +was inside a let binding. + +This version fixes the bug, moves the call to pick-worker outside the +let binding (so the bug would have shown up sooner) and also adds a +test for refresh view. + +It is also rebased on top of +id:1377547043-17584-1-git-send-email-markwalters1009@gmail.com so that +series should be applied first. + +Best wishes + +Mark + + +Mark Walters (3): + contrib: pick: remove unneeded variable notmuch-pick-buffer-name + contrib: pick: add docstring for notmuch-pick-worker + contrib: pick: test: refresh view + + contrib/notmuch-pick/notmuch-pick.el | 29 +++++++++++++---------------- + contrib/notmuch-pick/test/emacs-pick | 11 +++++++++++ + 2 files changed, 24 insertions(+), 16 deletions(-) + +-- +1.7.9.1 +