From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Sun, 19 Jan 2014 13:58:29 +0000 (+0200)
Subject: Re: test: (gnu) tar(1) portability
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=e62f5b78db96986aa230bf735fe2984c62b39750;p=notmuch-archives.git

Re: test: (gnu) tar(1) portability
---

diff --git a/7f/29d1ff8e009c8da53910ae3382ee22f12e9571 b/7f/29d1ff8e009c8da53910ae3382ee22f12e9571
new file mode 100644
index 000000000..804d62455
--- /dev/null
+++ b/7f/29d1ff8e009c8da53910ae3382ee22f12e9571
@@ -0,0 +1,90 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 1738E431FC2
+	for <notmuch@notmuchmail.org>; Sun, 19 Jan 2014 05:58:47 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id xWP1HmbItaen for <notmuch@notmuchmail.org>;
+	Sun, 19 Jan 2014 05:58:35 -0800 (PST)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+	by olra.theworths.org (Postfix) with ESMTP id 70C1C431FBD
+	for <notmuch@notmuchmail.org>; Sun, 19 Jan 2014 05:58:35 -0800 (PST)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+	by guru.guru-group.fi (Postfix) with ESMTP id 41E2C10005D;
+	Sun, 19 Jan 2014 15:58:29 +0200 (EET)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
+Subject: Re: test: (gnu) tar(1) portability
+In-Reply-To: <87ppny7bdq.fsf@zancas.localnet>
+References: <m2mwj2aj9w.fsf@guru.guru-group.fi>
+	<87ppny7bdq.fsf@zancas.localnet>
+User-Agent: Notmuch/0.17+34~g98b959f (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+	!)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Sun, 19 Jan 2014 15:58:29 +0200
+Message-ID: <m2ha906pkq.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sun, 19 Jan 2014 13:58:47 -0000
+
+On Sat, Jan 11 2014, David Bremner <david@tethera.net> wrote:
+
+> Tomi Ollila <tomi.ollila@iki.fi> writes:
+>>
+>> 2) Change calls to 'tar' to format ${GNU_TAR:-tar} so testers can set 
+>>    environment variable GNU_TAR to the name/path of gnu tar when running
+>>    tests (like GNU_TAR=/usr/local/bin/gtar make test or GNU_TAR=gtar ...)
+>
+> I don't really see any downside to this option; there's only a few calls
+> to tar to replace.  Of course we could bikeshed about whether to write 
+>
+> TAR=${GNU_TAR:-tar}
+> ...
+>
+> ${TAR} --frub --blah 
+>
+> instead of testing GNU_TAR everywhere.
+
+I also thought of this option, exactly in the same format, too.. 
+
+>
+> But, shrug...
+
+Yes... 
+
+and this leads to probably more problematic issue: Mac OS X has
+bash version 3 -- which cannot be used to run test scripts. For
+that we'd also need a variabe (and some test script trickiness).
+
+This bash issue is easier to solve by tuning the PATH instead of
+introducing another variable (or check for 'bash4' existence (ehhe;))
+There for we could (that's probably me, then ;/) just document that
+in test/README Prerequisites section..
+
+>
+> d
+
+Tomi
+