From: David Bremner Date: Mon, 8 Apr 2013 10:50:38 +0000 (+2100) Subject: Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el. X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=e622d3ca2e71e8ae99da0b6d05107745fb5e7f5b;p=notmuch-archives.git Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el. --- diff --git a/f9/a98fb82483d1b694f402150341244ead916f43 b/f9/a98fb82483d1b694f402150341244ead916f43 new file mode 100644 index 000000000..590c34921 --- /dev/null +++ b/f9/a98fb82483d1b694f402150341244ead916f43 @@ -0,0 +1,80 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1225C431FBF + for ; Mon, 8 Apr 2013 03:50:55 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id giMEDfWCldKu for ; + Mon, 8 Apr 2013 03:50:51 -0700 (PDT) +Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 4AF08431FAE + for ; Mon, 8 Apr 2013 03:50:51 -0700 (PDT) +Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net + ([156.34.82.78] helo=zancas.localnet) + by tesseract.cs.unb.ca with esmtpsa + (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) + (envelope-from ) + id 1UP9eu-0006A7-PU; Mon, 08 Apr 2013 07:50:45 -0300 +Received: from bremner by zancas.localnet with local (Exim 4.80) + (envelope-from ) + id 1UP9ep-0006nG-1v; Mon, 08 Apr 2013 07:50:39 -0300 +From: David Bremner +To: Jani Nikula , Tomi Ollila , + Karl Fogel +Subject: Re: [PATCH] emacs: add missing paren to fix defun in + notmuch-address.el. +In-Reply-To: <8738v1jtzc.fsf@nikula.org> +References: <87wqsfik5l.fsf@floss.red-bean.com> + <87mwtah2hd.fsf@zancas.localnet> + <877gkeau42.fsf@floss.red-bean.com> + <8738v1jtzc.fsf@nikula.org> +User-Agent: Notmuch/0.15.2+73~g1c450ec (http://notmuchmail.org) Emacs/24.2.1 + (x86_64-pc-linux-gnu) +Date: Mon, 08 Apr 2013 07:50:38 -0300 +Message-ID: <87k3odgutd.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-Spam_bar: - +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 08 Apr 2013 10:50:55 -0000 + +Jani Nikula writes: + +> On Mon, 08 Apr 2013, Tomi Ollila wrote: +>> The most tolerable way is to send new patch series w/ these 2 patches +>> that apply cleanly on top of current master (661dcf87aeb70) so that the +>> things that David needs to do are just to run `git am` and `make test`. +> +> I'd say just squash the two together. We already have the old reverted +> commit that doesn't build, let's not add another commit that breaks +> bisect (= every commit must build, work, and pass tests). +> +> BR, +> Jani. + +Squashed sounds good to me too. Sorry I'm too lazy/busy at the moment to +do it myself. + +d