From: David Bremner Date: Sat, 13 Aug 2016 11:31:53 +0000 (+0900) Subject: Re: [PATCH 9/9] add has: query prefix to search for specific properties X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=e4ff3e152cc3025e9226cc35f391ecd1abc726d5;p=notmuch-archives.git Re: [PATCH 9/9] add has: query prefix to search for specific properties --- diff --git a/b5/553880a290905597cb0f97ba56130b57ec15ba b/b5/553880a290905597cb0f97ba56130b57ec15ba new file mode 100644 index 000000000..aa887e35a --- /dev/null +++ b/b5/553880a290905597cb0f97ba56130b57ec15ba @@ -0,0 +1,82 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 54AF76DE383D + for ; Sat, 13 Aug 2016 04:32:10 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.007 +X-Spam-Level: +X-Spam-Status: No, score=-0.007 tagged_above=-999 required=5 tests=[AWL=0.004, + SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id GtSM4pTb33-I for ; + Sat, 13 Aug 2016 04:32:02 -0700 (PDT) +Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) + by arlo.cworth.org (Postfix) with ESMTPS id 5B5D66DE383A + for ; Sat, 13 Aug 2016 04:32:02 -0700 (PDT) +Received: from remotemail by fethera.tethera.net with local (Exim 4.84_2) + (envelope-from ) + id 1bYXAh-00048R-M5; Sat, 13 Aug 2016 07:32:11 -0400 +Received: (nullmailer pid 13567 invoked by uid 1000); + Sat, 13 Aug 2016 11:31:53 -0000 +From: David Bremner +To: Jani Nikula , notmuch@notmuchmail.org +Cc: Daniel Kahn Gillmor +Subject: Re: [PATCH 9/9] add has: query prefix to search for specific + properties +In-Reply-To: <87vaz580v3.fsf@nikula.org> +References: <1470491559-3946-1-git-send-email-david@tethera.net> + <1470491559-3946-10-git-send-email-david@tethera.net> + <87d1lm7zg2.fsf@maritornes.cs.unb.ca> <87vaz580v3.fsf@nikula.org> +User-Agent: Notmuch/0.22.1+61~g2ce0f13 (https://notmuchmail.org) Emacs/24.5.1 + (x86_64-pc-linux-gnu) +Date: Sat, 13 Aug 2016 20:31:53 +0900 +Message-ID: <87eg5s6h1y.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 13 Aug 2016 11:32:10 -0000 + +Jani Nikula writes: + +>> I don't really understand the comment on the next line (since it seems +>> that no : is added to XPROPERTY by Xapian), but I guess we should +>> probably be consistent. Maybe Jani can explain the comment? +> +> My recollection is vague, but it has to do with user-defined prefixes +> (XSOMETHING) and terms beginning with uppercase letters. I think it +> would possibly be useful (mandatory?) to append ":" at the end of +> XPROPERTY, if it's possible we'll have properties beginning with +> uppercase letters. +> +> Quoting https://xapian.org/docs/omega/termprefixes.html +> +> """ +> X starts a multi-capital letter user-defined prefix. If you want a +> prefix for something without a standard prefix, you create your own +> starting with an X (e.g. XSHOESIZE). The prefix ends with the first +> non-capital. If the term you're prefixing starts with a capital, add a +> ":" between prefix and term to resolve ambiguity about where the prefix +> ends and the term begins. +> """ + +Well, it seems harmless (modulo the 1 extra byte) to add it. I was +wondering if the comment (and requirement) dated back to when we added +XFOLDER: terms with some Xapian term generator, but I think I wasn't +able to verify that poking around in the history. + +d