From: Ezra Peisach <epeisach@mit.edu>
Date: Wed, 8 Apr 2009 15:25:43 +0000 (+0000)
Subject: Fall through on error return
X-Git-Tag: krb5-1.8-alpha1~558
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=e4a65c8b42384add772624273d1b03ba0689a3dc;p=krb5.git

Fall through on error return

If decoding the encoded_req_body fails, proceed goto errout instead of falling
through to fast handling.

Looks like a merge error.

Reindented code.

ticket: 6449

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@22183 dc483132-0cff-0310-8789-dd5450dbe970
---

diff --git a/src/kdc/do_as_req.c b/src/kdc/do_as_req.c
index 4f1715d67..0c4c92359 100644
--- a/src/kdc/do_as_req.c
+++ b/src/kdc/do_as_req.c
@@ -144,9 +144,10 @@ process_as_req(krb5_kdc_req *request, krb5_data *req_pkt,
     }
     if (fetch_asn1_field((unsigned char *) req_pkt->data,
 			 1, 4, &encoded_req_body) != 0) {
-    errcode = ASN1_BAD_ID;
-    status = "Finding req_body";
-}
+        errcode = ASN1_BAD_ID;
+        status = "Finding req_body";
+	goto errout;
+    }
     errcode = kdc_find_fast(&request, &encoded_req_body, NULL /*TGS key*/, NULL, state);
     if (errcode) {
 	status = "error decoding FAST";