From: Tomi Ollila Date: Sat, 15 Aug 2015 08:25:48 +0000 (+0300) Subject: Re: revision tracking patches round 4 X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=e48b07510e740970d7b3fbd5f3c4fbed64cc4018;p=notmuch-archives.git Re: revision tracking patches round 4 --- diff --git a/56/b5cb333949417e207f56057ac4bf5e13db94f3 b/56/b5cb333949417e207f56057ac4bf5e13db94f3 new file mode 100644 index 000000000..681a1f69c --- /dev/null +++ b/56/b5cb333949417e207f56057ac4bf5e13db94f3 @@ -0,0 +1,74 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id C2E746DE17FD + for ; Sat, 15 Aug 2015 01:26:17 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 1.238 +X-Spam-Level: * +X-Spam-Status: No, score=1.238 tagged_above=-999 required=5 tests=[AWL=-0.158, + SPF_NEUTRAL=0.652, URIBL_SBL=0.644, URIBL_SBL_A=0.1] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id Wn9VZuBNTqhf for ; + Sat, 15 Aug 2015 01:26:15 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by arlo.cworth.org (Postfix) with ESMTP id 12F186DE17F7 + for ; Sat, 15 Aug 2015 01:26:14 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id AE93A10008D; + Sat, 15 Aug 2015 11:25:48 +0300 (EEST) +From: Tomi Ollila +To: David Bremner , notmuch@notmuchmail.org +Subject: Re: revision tracking patches round 4 +In-Reply-To: <1439570878-15165-1-git-send-email-david@tethera.net> +References: <1439570878-15165-1-git-send-email-david@tethera.net> +User-Agent: Notmuch/0.20.2+61~g367bd06 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.18 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 15 Aug 2015 08:26:17 -0000 + +On Fri, Aug 14 2015, David Bremner wrote: + +> This obsoletes +> +> id:1439112285-6681-1-git-send-email-david@tethera.net +> +> The main differences since that series are in the command line syntax +> for notmuch-count. +> +> We also now consider passing --uuid to notmuch-compact an error, since +> the user might reasonably expect that to do something sensible, but we +> don't because of the existing API. + +Series LGTM. Tests pass. + +Looked a bit to xapian documentation... it seems in case of compacting +one should do the following: + +1) see that current database uuid is the one expected (which is stored +somewhere) +2) compact database +3) read new uuid and store it to "somewhere" + +Tomi