From: Zac Medico <zmedico@gentoo.org>
Date: Fri, 29 Oct 2010 23:29:37 +0000 (-0700)
Subject: Fix LazyItemsDict.__deepcopy__() for python 2.7.
X-Git-Tag: v2.1.9.24~3
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=e4813a9b821f1f941fdc1bd3bb7f0ad57a4b88fc;p=portage.git

Fix LazyItemsDict.__deepcopy__() for python 2.7.

In python-2.7, changes in deepcopy() make LazyItemsDict.__deepcopy__()
fail in some cases. Thanks to Diego E. Pettenò <flameeyes@g.o> for
reporting.
---

diff --git a/pym/portage/tests/ebuild/test_config.py b/pym/portage/tests/ebuild/test_config.py
index 9e2d2eaaa..9b6b13bab 100644
--- a/pym/portage/tests/ebuild/test_config.py
+++ b/pym/portage/tests/ebuild/test_config.py
@@ -10,6 +10,28 @@ from portage.tests.resolver.ResolverPlayground import ResolverPlayground, Resolv
 
 class ConfigTestCase(TestCase):
 
+	def testClone(self):
+		"""
+		Test the clone via constructor.
+		"""
+
+		ebuilds = {
+			"dev-libs/A-1": { },
+		}
+
+		playground = ResolverPlayground(ebuilds=ebuilds)
+		try:
+			settings = config(clone=playground.settings)
+			result = playground.run(["=dev-libs/A-1"])
+			pkg, existing_node = result.depgraph._select_package(
+				playground.root, "=dev-libs/A-1")
+			settings.setcpv(pkg)
+
+			# clone after setcpv tests deepcopy of LazyItemsDict
+			settings2 = config(clone=settings)
+		finally:
+			playground.cleanup()
+
 	def testFeaturesMutation(self):
 		"""
 		Test whether mutation of config.features updates the FEATURES
diff --git a/pym/portage/util/__init__.py b/pym/portage/util/__init__.py
index 0b0e0435e..d766690b3 100644
--- a/pym/portage/util/__init__.py
+++ b/pym/portage/util/__init__.py
@@ -1314,15 +1314,12 @@ class LazyItemsDict(UserDict):
 			k_copy = deepcopy(k, memo)
 			if k in self.lazy_items:
 				lazy_item = self.lazy_items[k]
-				try:
-					result.lazy_items[k_copy] = deepcopy(lazy_item, memo)
-				except TypeError:
-					if not lazy_item.singleton:
-						raise
-					UserDict.__setitem__(result,
-						k_copy, deepcopy(self[k], memo))
-				else:
-					UserDict.__setitem__(result, k_copy, None)
+				if not lazy_item.singleton:
+					raise TypeError("LazyItemsDict deepcopy is " + \
+						"unsafe with lazy items that " + \
+						"are not singletons: %s" % (lazy_item,))
+				UserDict.__setitem__(result,
+					k_copy, deepcopy(self[k], memo))
 			else:
 				UserDict.__setitem__(result, k_copy, deepcopy(self[k], memo))
 		return result