From: Tom Yu <tlyu@mit.edu>
Date: Fri, 28 Aug 2009 20:29:24 +0000 (+0000)
Subject: Remove bogus conditional from tcl_kadm5_randkey_principal(), which was
X-Git-Tag: krb5-1.8-alpha1~374
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=e2d100ad59c313807a43162225d049d6797933ff;p=krb5.git

Remove bogus conditional from tcl_kadm5_randkey_principal(), which was
causing unparse_keyblocks() to get stack garbage as num_keys when
num_var was "null", thus overrunning the end of the array.

ticket: 6544

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@22645 dc483132-0cff-0310-8789-dd5450dbe970
---

diff --git a/src/kadmin/testing/util/tcl_kadm5.c b/src/kadmin/testing/util/tcl_kadm5.c
index 15ae99fdd..6679ce0a7 100644
--- a/src/kadmin/testing/util/tcl_kadm5.c
+++ b/src/kadmin/testing/util/tcl_kadm5.c
@@ -2033,7 +2033,7 @@ static int tcl_kadm5_randkey_principal(ClientData clientData,
 
      ret = kadm5_randkey_principal(server_handle,
 				   princ, keyblock_var ? &keyblocks : 0,
-				   num_var ? &num_keys : 0);
+				   &num_keys);
 
      if (ret == KADM5_OK) {
 	  if (keyblock_var) {