From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Wed, 1 Jan 2014 14:53:22 +0000 (+0200)
Subject: Re: [PATCH] emacs: tree: bare-id in tree
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=e1aac25ce6996c85f5626550ed9f0b1a5637b525;p=notmuch-archives.git

Re: [PATCH] emacs: tree: bare-id in tree
---

diff --git a/8f/ec68db19612ac33610e0d04654c408fd7c5192 b/8f/ec68db19612ac33610e0d04654c408fd7c5192
new file mode 100644
index 000000000..3fe4c3704
--- /dev/null
+++ b/8f/ec68db19612ac33610e0d04654c408fd7c5192
@@ -0,0 +1,104 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id E6AC9431FC0
+	for <notmuch@notmuchmail.org>; Wed,  1 Jan 2014 06:53:32 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id MyABmHIkn9sc for <notmuch@notmuchmail.org>;
+	Wed,  1 Jan 2014 06:53:28 -0800 (PST)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+	by olra.theworths.org (Postfix) with ESMTP id 93C3C431FAF
+	for <notmuch@notmuchmail.org>; Wed,  1 Jan 2014 06:53:28 -0800 (PST)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+	by guru.guru-group.fi (Postfix) with ESMTP id 8A8E01000B2;
+	Wed,  1 Jan 2014 16:53:22 +0200 (EET)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
+Subject: Re: [PATCH] emacs: tree: bare-id in tree
+In-Reply-To: <1387480611-15789-1-git-send-email-markwalters1009@gmail.com>
+References: <1387480611-15789-1-git-send-email-markwalters1009@gmail.com>
+User-Agent: Notmuch/0.17+13~gdfcf116 (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+	!)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Wed, 01 Jan 2014 16:53:22 +0200
+Message-ID: <m2zjnfoisd.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Wed, 01 Jan 2014 14:53:33 -0000
+
+On Thu, Dec 19 2013, Mark Walters <markwalters1009@gmail.com> wrote:
+
+> Previously notmuch-tree-get-message-id always returned the id
+> including the prefix "id:". Modify the function to take an optional
+> `bare' argument saying to return the raw string.
+>
+> This will be useful later and brings the function in line with
+> notmuch-show-get-message-id.
+> ---
+
+LGTM.
+
+Tomi
+
+
+> This functionality will be useful later. I think it reasonable to put
+> it in now as it does bring notmuch-tree-get-message-id in line with
+> notmuch-show-get-message-id which already has this option.
+>
+> Best wishes
+>
+> Mark
+>
+>
+>  emacs/notmuch-tree.el |    6 ++++--
+>  1 files changed, 4 insertions(+), 2 deletions(-)
+>
+> diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el
+> index 8d59e65..1dde9a7 100644
+> --- a/emacs/notmuch-tree.el
+> +++ b/emacs/notmuch-tree.el
+> @@ -319,11 +319,13 @@ correct message properties."
+>    "Return the tags of the current message."
+>    (notmuch-tree-get-prop :tags))
+>  
+> -(defun notmuch-tree-get-message-id ()
+> +(defun notmuch-tree-get-message-id (&optional bare)
+>    "Return the message id of the current message."
+>    (let ((id (notmuch-tree-get-prop :id)))
+>      (if id
+> -	(notmuch-id-to-query id)
+> +	(if bare
+> +	    id
+> +	  (notmuch-id-to-query id))
+>        nil)))
+>  
+>  (defun notmuch-tree-get-match ()
+> -- 
+> 1.7.9.1
+>
+> _______________________________________________
+> notmuch mailing list
+> notmuch@notmuchmail.org
+> http://notmuchmail.org/mailman/listinfo/notmuch