From: David Bremner Date: Sat, 29 Mar 2014 12:29:15 +0000 (+2100) Subject: Re: [PATCH] RFC: impliment gzipped output for notmuch dump X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=e1a80feae3cdbafde7d4965549e5df5c00eb3b3e;p=notmuch-archives.git Re: [PATCH] RFC: impliment gzipped output for notmuch dump --- diff --git a/6e/cb508f39659726ee765d070ecab37d9043fb30 b/6e/cb508f39659726ee765d070ecab37d9043fb30 new file mode 100644 index 000000000..3c0f1b489 --- /dev/null +++ b/6e/cb508f39659726ee765d070ecab37d9043fb30 @@ -0,0 +1,79 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id CADFA431FBF + for ; Sat, 29 Mar 2014 05:29:32 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 8C33c-TSxYUM for ; + Sat, 29 Mar 2014 05:29:22 -0700 (PDT) +Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 6E0B6431FBC + for ; Sat, 29 Mar 2014 05:29:22 -0700 (PDT) +Received: from remotemail by yantan.tethera.net with local (Exim 4.80) + (envelope-from ) + id 1WTsNy-0006d3-R7; Sat, 29 Mar 2014 09:29:18 -0300 +Received: (nullmailer pid 28304 invoked by uid 1000); Sat, 29 Mar 2014 + 12:29:15 -0000 +From: David Bremner +To: Jani Nikula , notmuch@notmuchmail.org +Subject: Re: [PATCH] RFC: impliment gzipped output for notmuch dump +In-Reply-To: <87wqfdbblz.fsf@nikula.org> +References: <874n2kipq4.fsf@qmul.ac.uk> + <1396056046-2247-1-git-send-email-david@tethera.net> + <87wqfdbblz.fsf@nikula.org> +User-Agent: Notmuch/0.17+150~g2743557 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Sat, 29 Mar 2014 09:29:15 -0300 +Message-ID: <87ob0pdw84.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 29 Mar 2014 12:29:33 -0000 + +Jani Nikula writes: + +> Is it reasonable to require zlib? It's possible to have conditional +> build for this, but it will be laborous to do it cleanly. I could be +> persuaded either way, perhaps more easily to just requiring it. + +If I recall correctly, xapian needs zlib. At least on Debian this is a +hard dependency. What is needed additionally is the zlib headers. + +> If you do require zlib, the missing dependencies error message from +> configure should include a check for have_zlib and a note about it +> similar to other required dependencies. + +good point. + +> Also, it would seem natural to support gzipped input in restore as +> well... do you think it would be silly to support gzipped output only +> internally until we've added gzipped input too? This could be in a later +> release in the future. + +I couldn't decide which was sillier: to have have gzipped output but not +input, or to leave off the command line argument (it's something like 3 +lines of diff). I lean to making it accessible from the CLI to better +support testing. + +d