From: David Bremner Date: Thu, 8 May 2014 22:14:15 +0000 (+0900) Subject: Re: [PATCH 2/5] configure, test: Added variables for paths to true and false. X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=de763749b33e2f0479f1be93988a4f5cb463a12d;p=notmuch-archives.git Re: [PATCH 2/5] configure, test: Added variables for paths to true and false. --- diff --git a/2d/61219be77a97144beff247e298244d74fc5091 b/2d/61219be77a97144beff247e298244d74fc5091 new file mode 100644 index 000000000..13b9346ed --- /dev/null +++ b/2d/61219be77a97144beff247e298244d74fc5091 @@ -0,0 +1,78 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 4A9E2431FBF + for ; Thu, 8 May 2014 15:15:59 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id tS7dwS9Dl8mL for ; + Thu, 8 May 2014 15:15:52 -0700 (PDT) +Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net + [87.98.215.224]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id E9D2F431FAE + for ; Thu, 8 May 2014 15:15:51 -0700 (PDT) +Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim + 4.72) (envelope-from ) + id 1WiWaJ-0000OH-7m; Thu, 08 May 2014 22:14:35 +0000 +Received: (nullmailer pid 12559 invoked by uid 1000); Thu, 08 May 2014 + 22:14:15 -0000 +From: David Bremner +To: Charles Celerier , notmuch@notmuchmail.org +Subject: Re: [PATCH 2/5] configure, test: Added variables for paths to true + and false. +In-Reply-To: +References: <1399395748-44920-1-git-send-email-cceleri@cs.stanford.edu> + <1399395748-44920-2-git-send-email-cceleri@cs.stanford.edu> + <1399395748-44920-3-git-send-email-cceleri@cs.stanford.edu> + <87fvkkv4bc.fsf@maritornes.cs.unb.ca> +User-Agent: Notmuch/0.18 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Fri, 09 May 2014 07:14:15 +0900 +Message-ID: <877g5vvryg.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 08 May 2014 22:15:59 -0000 + +Charles Celerier writes: + +> I will be the first too admit that I do not know much about configure +> scripts, but adding a TRUE variable seemed straightforward. + +configure is already big enough, I'd prefer not to add new things unless +they are needed. This is not likely to be something the user wants to +change, and (as you note below) it's pretty easy for the the Makefile or +tests to guess. + +> You could use `$(which true)` in test/Makefile.local, but I felt the +> code repetition there was unecessary since you could just create a +> TRUE variable in the configure script. + +well, it's not really code repetition because it is only used in that +one place. + +> An alternative is to change the tests so that the location of true +> (and false) is no longer an issue. + +Sure, that would be fine too. + +d