From: Tomi Ollila Date: Fri, 2 Jan 2015 19:54:04 +0000 (+0200) Subject: Re: [PATCH v3] emacs: add stash support for git send-email command line X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=dd93ff5288e9106d6168d970255389ae4b40c544;p=notmuch-archives.git Re: [PATCH v3] emacs: add stash support for git send-email command line --- diff --git a/a7/6772caafac0f306d41e30d5b9d37cb070ee5f8 b/a7/6772caafac0f306d41e30d5b9d37cb070ee5f8 new file mode 100644 index 000000000..752f57c23 --- /dev/null +++ b/a7/6772caafac0f306d41e30d5b9d37cb070ee5f8 @@ -0,0 +1,141 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 835AB431FAF + for ; Fri, 2 Jan 2015 11:54:37 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 2IFXhp0-poob for ; + Fri, 2 Jan 2015 11:54:33 -0800 (PST) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 78CF5431FAE + for ; Fri, 2 Jan 2015 11:54:33 -0800 (PST) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 9630D100051; + Fri, 2 Jan 2015 21:54:04 +0200 (EET) +From: Tomi Ollila +To: David Edmondson , Jani Nikula , + notmuch@notmuchmail.org +Subject: Re: [PATCH v3] emacs: add stash support for git send-email + command line +In-Reply-To: +References: + <1420220897-6245-1-git-send-email-jani@nikula.org> + +User-Agent: Notmuch/0.19+6~g8725b09 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 02 Jan 2015 19:54:37 -0000 + +On Fri, Jan 02 2015, David Edmondson wrote: + +> Looks good to me. + + +LGTM, too, and seems to work -- and docstrings actually adhere the +conventions... + +from http://web.mit.edu/Emacs/source/emacs/lisp/emacs-lisp/checkdoc.el + + ;; * Format the documentation string so that it fits in an + ;; Emacs window on an 80-column screen. It is a good idea + ;; for most lines to be no wider than 60 characters. The + ;; first line can be wider if necessary to fit the + ;; information that ought to be there. + +Tomi + +> On Fri, Jan 02 2015, Jani Nikula wrote: +>> Stash From/To/Cc as --to/--to/--cc, respectively, and Message-Id as +>> --in-reply-to, suitable for pasting to git send-email command line. +>> --- +>> emacs/notmuch-show.el | 38 ++++++++++++++++++++++++++++++++++++++ +>> 1 file changed, 38 insertions(+) +>> +>> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el +>> index b8cfbb8a3286..9f6fe077df0c 100644 +>> --- a/emacs/notmuch-show.el +>> +++ b/emacs/notmuch-show.el +>> @@ -1280,6 +1280,7 @@ reset based on the original query." +>> (define-key map "t" 'notmuch-show-stash-to) +>> (define-key map "l" 'notmuch-show-stash-mlarchive-link) +>> (define-key map "L" 'notmuch-show-stash-mlarchive-link-and-go) +>> + (define-key map "G" 'notmuch-show-stash-git-send-email) +>> (define-key map "?" 'notmuch-subkeymap-help) +>> map) +>> "Submap for stash commands") +>> @@ -2131,6 +2132,43 @@ the user (see `notmuch-show-stash-mlarchive-link-alist')." +>> (notmuch-show-stash-mlarchive-link mla) +>> (browse-url (current-kill 0 t))) +>> +>> +(defun notmuch-show-stash-git-helper (addresses prefix) +>> + "Escape, trim, quote, and add PREFIX to each address in list of ADDRESSES, and return the result as a single string." +>> + (mapconcat (lambda (x) +>> + (concat prefix "\"" +>> + ;; escape double-quotes +>> + (replace-regexp-in-string +>> + "\"" "\\\\\"" +>> + ;; trim leading and trailing spaces +>> + (replace-regexp-in-string +>> + "\\(^ *\\| *$\\)" "" +>> + x)) "\"")) +>> + addresses " ")) +>> + +>> +(put 'notmuch-show-stash-git-send-email 'notmuch-prefix-doc +>> + "Copy From/To/Cc of current message to kill-ring in a form suitable for pasting to git send-email command line.") +>> + +>> +(defun notmuch-show-stash-git-send-email (&optional no-in-reply-to) +>> + "Copy From/To/Cc/Message-Id of current message to kill-ring in a form suitable for pasting to git send-email command line. +>> + +>> +If invoked with a prefix argument (or NO-IN-REPLY-TO is non-nil), +>> +omit --in-reply-to=." +>> + (interactive "P") +>> + (notmuch-common-do-stash +>> + (mapconcat 'identity +>> + (remove "" +>> + (list +>> + (notmuch-show-stash-git-helper +>> + (message-tokenize-header (notmuch-show-get-from)) "--to=") +>> + (notmuch-show-stash-git-helper +>> + (message-tokenize-header (notmuch-show-get-to)) "--to=") +>> + (notmuch-show-stash-git-helper +>> + (message-tokenize-header (notmuch-show-get-cc)) "--cc=") +>> + (unless no-in-reply-to +>> + (notmuch-show-stash-git-helper +>> + (list (notmuch-show-get-message-id t)) "--in-reply-to=")))) +>> + " "))) +>> + +>> ;; Interactive part functions and their helpers +>> +>> (defun notmuch-show-generate-part-buffer (message-id nth) +>> -- +>> 2.1.4 +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch