From: Trevor Jim Date: Tue, 3 Mar 2015 16:22:54 +0000 (+1900) Subject: Re: [PATCH] go: add binding for notmuch_message_get_date X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=dd6411e06f1a3d80da66eccb0f856763d7417872;p=notmuch-archives.git Re: [PATCH] go: add binding for notmuch_message_get_date --- diff --git a/fb/182304456b657a9aa8cf5119e110e6c312ddb4 b/fb/182304456b657a9aa8cf5119e110e6c312ddb4 new file mode 100644 index 000000000..620ee46bb --- /dev/null +++ b/fb/182304456b657a9aa8cf5119e110e6c312ddb4 @@ -0,0 +1,77 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 63EC5431FB6 + for ; Tue, 3 Mar 2015 08:24:56 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0.139 +X-Spam-Level: +X-Spam-Status: No, score=0.139 tagged_above=-999 required=5 + tests=[DNS_FROM_AHBL_RHSBL=2.438, FREEMAIL_FROM=0.001, + RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id TBUpavKBx7e6 for ; + Tue, 3 Mar 2015 08:24:53 -0800 (PST) +Received: from nk11p00mm-asmtp002.mac.com (nk11p00mm-asmtp002.mac.com + [17.158.161.1]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 2FCB0431FAF + for ; Tue, 3 Mar 2015 08:24:53 -0800 (PST) +Received: from localhost (aegis.CS.Princeton.EDU [128.112.139.195]) + by nk11p00mm-asmtp002.mac.com + (Oracle Communications Messaging Server 7.0.5.35.0 64bit (built Dec 4 + 2014)) + with ESMTPSA id <0NKN00FC69I7D300@nk11p00mm-asmtp002.mac.com> for + notmuch@notmuchmail.org; Tue, 03 Mar 2015 16:22:57 +0000 (GMT) +X-Proofpoint-Virus-Version: vendor=fsecure + engine=2.50.10432:5.13.68,1.0.33,0.0.0000 + definitions=2015-03-03_05:2015-03-03, 2015-03-03, + 1970-01-01 signatures=0 +X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 + suspectscore=1 phishscore=0 adultscore=0 bulkscore=0 classifier=spam + adjust=0 + reason=mlx scancount=1 engine=7.0.1-1412110000 + definitions=main-1503030177 +From: Trevor Jim +To: David Bremner , Tomi Ollila , + notmuch@notmuchmail.org +Subject: Re: [PATCH] go: add binding for notmuch_message_get_date +In-reply-to: <87385mmasu.fsf@maritornes.cs.unb.ca> +References: + <87385mmasu.fsf@maritornes.cs.unb.ca> +Date: Tue, 03 Mar 2015 11:22:54 -0500 +Message-id: +MIME-version: 1.0 +Content-type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 03 Mar 2015 16:24:56 -0000 + +> Given the current troubles with the main library API and missing status +> values, I'd say in the long run we'll be happier with a real status +> return. OTOH, I don't much about go. + +I'm not sure what the "current troubles" are (happy to hear more), but +the way I've handled the nil case is in keeping with the way it's +handled in the other function bindings for go. Adding an error return +to all relevant functions seems like a big change that should be handled +separately, yes? + +In defense of the current strategy, any caller can check for the nil +case before calling. + +-T