From: Daniel Kahn Gillmor Date: Fri, 11 Dec 2015 14:36:42 +0000 (+1900) Subject: Re: [PATCH 2/9] Add a lazily-initialized crypto context to notmuch_database_t X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=dd4d9d2e72216f01a3601b1e5e54afd7d0e7e347;p=notmuch-archives.git Re: [PATCH 2/9] Add a lazily-initialized crypto context to notmuch_database_t --- diff --git a/98/1998e871f86be823407088365bfa965971fc40 b/98/1998e871f86be823407088365bfa965971fc40 new file mode 100644 index 000000000..03fe2b0bd --- /dev/null +++ b/98/1998e871f86be823407088365bfa965971fc40 @@ -0,0 +1,80 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 5EA326DE0A9A + for ; Fri, 11 Dec 2015 06:36:46 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.017 +X-Spam-Level: +X-Spam-Status: No, score=-0.017 tagged_above=-999 required=5 + tests=[AWL=-0.017] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id lVevpNoNwfwj for ; + Fri, 11 Dec 2015 06:36:44 -0800 (PST) +Received: from che.mayfirst.org (che.mayfirst.org [209.234.253.108]) + by arlo.cworth.org (Postfix) with ESMTP id 86DF46DE0B4B + for ; Fri, 11 Dec 2015 06:36:44 -0800 (PST) +Received: from fifthhorseman.net (unknown [38.109.115.130]) + by che.mayfirst.org (Postfix) with ESMTPSA id B004BF984; + Fri, 11 Dec 2015 09:36:42 -0500 (EST) +Received: by fifthhorseman.net (Postfix, from userid 1000) + id B7E8F2006D; Fri, 11 Dec 2015 09:36:42 -0500 (EST) +From: Daniel Kahn Gillmor +To: David Bremner , Notmuch Mail +Subject: Re: [PATCH 2/9] Add a lazily-initialized crypto context to + notmuch_database_t +In-Reply-To: <871tatf5gm.fsf@zancas.localnet> +References: <1449718786-28000-1-git-send-email-dkg@fifthhorseman.net> + <1449718786-28000-3-git-send-email-dkg@fifthhorseman.net> + <871tatf5gm.fsf@zancas.localnet> +User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 + (x86_64-pc-linux-gnu) +Date: Fri, 11 Dec 2015 09:36:42 -0500 +Message-ID: <8737v9hx1h.fsf@alice.fifthhorseman.net> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 11 Dec 2015 14:36:46 -0000 + +On Fri 2015-12-11 09:03:05 -0500, David Bremner wrote: +> Daniel Kahn Gillmor writes: +> +>> This is in large part a duplicate of parts of crypto.c, but that code +>> is in the client (outside the library), and we don't want to entangle +>> the libgmime API with the libnotmuch API. +>> +>> I welcome better proposals for how to share this code explicitly +>> between the library and the client. +> +> Maybe I miss something obvious, but util/libutil.a is exactly there for +> sharing code between the library and the client. + +You didn't miss anything obvious -- i did! Thanks for pointing that +out, i'll take a look at normalizing these bits for my second draft. + +> perhaps something like "gmime-extra.c" to go with {talloc,zlib}-extra.c + +right, sounds good. + +> I didn't look at the code yet, just the commentary. + +many thanks for the review, that's why i wrote the commentary :) + +After a couple nights of sleep, i have a proposal to fix one of the +open questions too, which i'll follow up on shortly here. + + --dkg