From: David Bremner Date: Mon, 6 Oct 2014 06:19:10 +0000 (+0200) Subject: Re: [PATCH 06/11] lib: Internal support for querying and creating ghost messages X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=dd009132a23ed94bb8919839ffc5d9fae1bb9bcf;p=notmuch-archives.git Re: [PATCH 06/11] lib: Internal support for querying and creating ghost messages --- diff --git a/5d/9eb3c8a931ef8236bcafcf317b1abd0c13226b b/5d/9eb3c8a931ef8236bcafcf317b1abd0c13226b new file mode 100644 index 000000000..8b4101ef1 --- /dev/null +++ b/5d/9eb3c8a931ef8236bcafcf317b1abd0c13226b @@ -0,0 +1,85 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id CC126431FB6 + for ; Sun, 5 Oct 2014 23:19:27 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id cRugj8BNvxic for ; + Sun, 5 Oct 2014 23:19:20 -0700 (PDT) +Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id C4BC0431FAE + for ; Sun, 5 Oct 2014 23:19:20 -0700 (PDT) +Received: from remotemail by yantan.tethera.net with local (Exim 4.80) + (envelope-from ) + id 1Xb1dg-0004LZ-5i; Mon, 06 Oct 2014 03:19:20 -0300 +Received: (nullmailer pid 18837 invoked by uid 1000); Mon, 06 Oct 2014 + 06:19:10 -0000 +From: David Bremner +To: Austin Clements +Subject: Re: [PATCH 06/11] lib: Internal support for querying and creating + ghost messages +In-Reply-To: <20141005232400.GC7970@csail.mit.edu> +References: <1412345958-8278-1-git-send-email-aclements@csail.mit.edu> + <1412345958-8278-7-git-send-email-aclements@csail.mit.edu> + <87fvf2q5p5.fsf@maritornes.cs.unb.ca> + <20141005232400.GC7970@csail.mit.edu> +User-Agent: Notmuch/0.18.1+98~gae27403 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Mon, 06 Oct 2014 08:19:10 +0200 +Message-ID: <87y4stoh41.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 06 Oct 2014 06:19:27 -0000 + +Austin Clements writes: + +> +> I'm used to reading this stuff, so either way is fine with me. Do we +> have bit set / clear / read macros? +> + +I guess not. the things we have in query.cc are related but different. + +>> > + else if (*i == "Tghost") +>> > + message->flags |= (1 << NOTMUCH_MESSAGE_FLAG_GHOST); +>> > + else +>> +>> It makes me faintly unhappy to have the prefix hardcoded here. +>> Not sure if there is a sensible solution. +> +> I agree, but I also don't want to construct the test string every time +> or deconstruct the term string every time. I could move the "T" +> prefix string to a #define and use that both here and in +> BOOLEAN_PREFIX_INTERNAL, but that solution may be worse than the +> problem. What do you think? + +Maybe just a comment to point to BOOLEAN_PREFIX_INTERNAL. + +Or maybe define a macro right beside BOOLEAN_PREFIX_INTERNAL like + +#define ADD_TYPE_PREFIX(s) "T" s + +At least then the duplication is all in one place.