From: Jani Nikula Date: Tue, 3 Sep 2013 05:22:18 +0000 (+0300) Subject: Re: [PATCH] test: update insert tests for new maildir synchronization rules X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=dce0c6ada71ee4c6dfd9170d41a70b14261565c8;p=notmuch-archives.git Re: [PATCH] test: update insert tests for new maildir synchronization rules --- diff --git a/95/3308615df344009b21a6dff6b0ee2bb321e30a b/95/3308615df344009b21a6dff6b0ee2bb321e30a new file mode 100644 index 000000000..8a7828440 --- /dev/null +++ b/95/3308615df344009b21a6dff6b0ee2bb321e30a @@ -0,0 +1,132 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 19E62429E25 + for ; Mon, 2 Sep 2013 22:22:37 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id ckSbAXnp3vw4 for ; + Mon, 2 Sep 2013 22:22:22 -0700 (PDT) +Received: from mail-ea0-f170.google.com (mail-ea0-f170.google.com + [209.85.215.170]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 2A133431FDD + for ; Mon, 2 Sep 2013 22:22:22 -0700 (PDT) +Received: by mail-ea0-f170.google.com with SMTP id h14so2736478eak.29 + for ; Mon, 02 Sep 2013 22:22:20 -0700 (PDT) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:from:to:cc:subject:in-reply-to:references + :user-agent:date:message-id:mime-version:content-type; + bh=774inoBzsvYpQLgZ3pkxfsePb5Zj+BKQFctTBX9jkHA=; + b=Xj+4aZFvzRJCLSFQenb1VNHmKsZcJUvRxT3rVDyRTlsgSdoNey0d2AtoGK/wDT0rS/ + fcO/ZIbW9kPI+S+8o7iVIuOwI2clJmR0wOv1Tr+o4ZgbzvlzyoRnN7g+dLA//9HszP/l + /adZlC83W60KzFS8cCLfvp7//FIYoEGpTeeNFHg/1o5wOya6JdtA57+DWA3PSo2OASDn + kz373g0qZdRYUpWYc1wAY1DBIh0LTU6T3OPxJZIrZ6uI5Jv7kUzbbTLsugz00eapixSU + CM2BZlq6YQcwopwAtr5pbA2pTINEwt/ymCyiWt8BEx8BCUEF4oRoTrtlHa8oRECR9M8J + IT1A== +X-Gm-Message-State: + ALoCoQnWEDSc8ZMNzGRoXWXsn3mGiJrfTvVx0FvqySLlFgEm9Icq/LAafOKuDQkzSUxDB70jsBo2 +X-Received: by 10.14.107.137 with SMTP id o9mr4962eeg.86.1378185739531; + Mon, 02 Sep 2013 22:22:19 -0700 (PDT) +Received: from localhost (dsl-hkibrasgw2-58c36f-91.dhcp.inet.fi. + [88.195.111.91]) + by mx.google.com with ESMTPSA id b45sm28246810eef.4.1969.12.31.16.00.00 + (version=TLSv1.2 cipher=RC4-SHA bits=128/128); + Mon, 02 Sep 2013 22:22:18 -0700 (PDT) +From: Jani Nikula +To: david@tethera.net, notmuch@notmuchmail.org +Subject: Re: [PATCH] test: update insert tests for new maildir synchronization + rules +In-Reply-To: <1378170613-3584-1-git-send-email-david@tethera.net> +References: <1355952747-27350-4-git-send-email-sojkam1@fel.cvut.cz> + <1378170613-3584-1-git-send-email-david@tethera.net> +User-Agent: Notmuch/0.16+39~gf3963b0 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Tue, 03 Sep 2013 08:22:18 +0300 +Message-ID: <87ob8ao4xh.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain +Cc: David Bremner +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 03 Sep 2013 05:22:38 -0000 + +On Tue, 03 Sep 2013, david@tethera.net wrote: +> From: David Bremner +> +> As of id:1355952747-27350-4-git-send-email-sojkam1@fel.cvut.cz +> we are more conservative about moving messages from ./new to ./cur. +> This updates the insert tests to match +> --- +> +> Hopefully this makes sense, and is not just papering over a real +> problem that should be fixed. + +LGTM. I sent some additional tests on top. + +Jani. + + + +> +> test/insert | 6 +++--- +> 1 file changed, 3 insertions(+), 3 deletions(-) +> +> diff --git a/test/insert b/test/insert +> index 021edb6..1718120 100755 +> --- a/test/insert +> +++ b/test/insert +> @@ -82,7 +82,7 @@ gen_insert_msg +> notmuch insert --folder=Drafts < "$gen_msg_filename" +> output=$(notmuch search --output=files folder:Drafts) +> dirname=$(dirname "$output") +> -test_expect_equal "$dirname" "$MAIL_DIR/Drafts/cur" +> +test_expect_equal "$dirname" "$MAIL_DIR/Drafts/new" +> +> test_begin_subtest "Insert message into folder, add/remove tags" +> gen_insert_msg +> @@ -99,14 +99,14 @@ gen_insert_msg +> notmuch insert --folder=F --create-folder +folder < "$gen_msg_filename" +> output=$(notmuch search --output=files folder:F tag:folder) +> basename=$(basename "$output") +> -test_expect_equal_file "$gen_msg_filename" "$MAIL_DIR/F/cur/${basename}" +> +test_expect_equal_file "$gen_msg_filename" "$MAIL_DIR/F/new/${basename}" +> +> test_begin_subtest "Insert message, create subfolder" +> gen_insert_msg +> notmuch insert --folder=F/G/H/I/J --create-folder +folder < "$gen_msg_filename" +> output=$(notmuch search --output=files folder:F/G/H/I/J tag:folder) +> basename=$(basename "$output") +> -test_expect_equal_file "$gen_msg_filename" "${MAIL_DIR}/F/G/H/I/J/cur/${basename}" +> +test_expect_equal_file "$gen_msg_filename" "${MAIL_DIR}/F/G/H/I/J/new/${basename}" +> +> test_begin_subtest "Insert message, create existing subfolder" +> gen_insert_msg +> -- +> 1.8.3.2 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch + +-- +Jani