From: David Bremner Date: Mon, 26 Jan 2015 22:59:40 +0000 (+0100) Subject: Re: [Patch v4 5/5] test: add broken test for SMIME decryption with notmuch CLI X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=dc3dfa28c6b88b5aa166d932264e0bd797f731cf;p=notmuch-archives.git Re: [Patch v4 5/5] test: add broken test for SMIME decryption with notmuch CLI --- diff --git a/1c/5c871f592876023eef94bea7b7b90ca3711927 b/1c/5c871f592876023eef94bea7b7b90ca3711927 new file mode 100644 index 000000000..9cf3ab79a --- /dev/null +++ b/1c/5c871f592876023eef94bea7b7b90ca3711927 @@ -0,0 +1,71 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 26F2F431FC2 + for ; Mon, 26 Jan 2015 15:02:00 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 2.438 +X-Spam-Level: ** +X-Spam-Status: No, score=2.438 tagged_above=-999 required=5 + tests=[DNS_FROM_AHBL_RHSBL=2.438] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id DkHGcynrIxV1 for ; + Mon, 26 Jan 2015 15:01:57 -0800 (PST) +Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net + [87.98.215.224]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id DC35E431FAF + for ; Mon, 26 Jan 2015 15:01:56 -0800 (PST) +Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim + 4.80) (envelope-from ) + id 1YFsdO-0008HP-3Z; Mon, 26 Jan 2015 22:59:54 +0000 +Received: (nullmailer pid 13535 invoked by uid 1000); Mon, 26 Jan 2015 + 22:59:40 -0000 +From: David Bremner +To: notmuch@notmuchmail.org +Subject: Re: [Patch v4 5/5] test: add broken test for SMIME decryption with + notmuch CLI +In-Reply-To: <1421568167-18683-6-git-send-email-david@tethera.net> +References: <1421568167-18683-1-git-send-email-david@tethera.net> + <1421568167-18683-6-git-send-email-david@tethera.net> +User-Agent: Notmuch/0.19+48~gb74ed1c (http://notmuchmail.org) Emacs/24.4.1 + (x86_64-pc-linux-gnu) +Date: Mon, 26 Jan 2015 23:59:40 +0100 +Message-ID: <87h9vdup0j.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 26 Jan 2015 23:02:00 -0000 + +David Bremner writes: + +> The test JSON here is not correct, but the larger problem is thatit +> seems like no actual decryption is being done. + +I played with this some more, and it seems like Jamie's code (and the +gmime sample code [1] expects the top level part to be +multipart/encrypted. Message-mode on the other hand generates messages +with a single application/x-pkcs7-mime part. According to my reading of +rfc5751 section 3.9, they're both wrong. 'application/pkcs7-mime' is +legit, as is, wait for it, "application/octet-stream" with a file suffix +of "p7m", "p7s", "p7c", or "p7z". So I guess we have to check for +x-pkcs7-mime as well? Apparently this has only been a known problem [2] +for 15 years or so. + +[1]: https://github.com/GNOME/gmime/blob/master/tests/test-smime.c +[2]: http://www.imc.org/ietf-smime/mail-archive/msg00726.html