From: Zac Medico <zmedico@gentoo.org>
Date: Fri, 7 Dec 2007 09:59:48 +0000 (-0000)
Subject: Add a TODO note about remaining work for bug #189417.
X-Git-Tag: v2.2_pre1~211
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=dbdfdfb8498923f1ac30618b0be4c5a9c2e0b2c8;p=portage.git

Add a TODO note about remaining work for bug #189417.

svn path=/main/trunk/; revision=8864
---

diff --git a/pym/portage/__init__.py b/pym/portage/__init__.py
index e5c73d116..545e33afa 100644
--- a/pym/portage/__init__.py
+++ b/pym/portage/__init__.py
@@ -2583,6 +2583,11 @@ class config(object):
 			if filter_calling_env and \
 				x not in environ_whitelist and \
 				not self._environ_whitelist_re.match(x):
+				# TODO: Complete the whitelist so that comparisons with
+				# environment variables are not necessary. We want to
+				# prevent all but whitelisted variables from being able
+				# to leak into the environment, so a variable can be unset
+				# and it will remain unset for all phases (bug #189417).
 				if myvalue == env_d.get(x) or \
 					myvalue == os.environ.get(x):
 					continue