From: David Bremner <david@tethera.net>
Date: Sat, 5 Jul 2014 12:43:58 +0000 (+2100)
Subject: Re: [PATCH v2 03/10] python: handle return status of database close and	destroy
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=dba3bef1dd6a307d33d574c3644eb03bd211a578;p=notmuch-archives.git

Re: [PATCH v2 03/10] python: handle return status of database close and	destroy
---

diff --git a/f5/a3e65bca75319308e62ddb0bc453dcde658892 b/f5/a3e65bca75319308e62ddb0bc453dcde658892
new file mode 100644
index 000000000..e56d71ae5
--- /dev/null
+++ b/f5/a3e65bca75319308e62ddb0bc453dcde658892
@@ -0,0 +1,67 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 5AA8E431FB6
+	for <notmuch@notmuchmail.org>; Sat,  5 Jul 2014 05:46:16 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id 8bE8fmvFDMpt for <notmuch@notmuchmail.org>;
+	Sat,  5 Jul 2014 05:46:10 -0700 (PDT)
+Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net
+	[87.98.215.224]) (using TLSv1 with cipher AES256-SHA (256/256 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id C90A8431FAF
+	for <notmuch@notmuchmail.org>; Sat,  5 Jul 2014 05:46:10 -0700 (PDT)
+Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim
+	4.72) (envelope-from <david@tethera.net>)
+	id 1X3PKD-0005oW-IA; Sat, 05 Jul 2014 12:44:17 +0000
+Received: (nullmailer pid 23741 invoked by uid 1000); Sat, 05 Jul 2014
+	12:43:58 -0000
+From: David Bremner <david@tethera.net>
+To: Peter Wang <novalazy@gmail.com>, notmuch@notmuchmail.org
+Subject: Re: [PATCH v2 03/10] python: handle return status of database close
+	and	destroy
+In-Reply-To: <1397653165-15620-4-git-send-email-novalazy@gmail.com>
+References: <1397653165-15620-1-git-send-email-novalazy@gmail.com>
+	<1397653165-15620-4-git-send-email-novalazy@gmail.com>
+User-Agent: Notmuch/0.18.1+22~gbf82697 (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-pc-linux-gnu)
+Date: Sat, 05 Jul 2014 09:43:58 -0300
+Message-ID: <87y4w8q8kx.fsf@maritornes.cs.unb.ca>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sat, 05 Jul 2014 12:46:16 -0000
+
+Peter Wang <novalazy@gmail.com> writes:
+
+> Throw an exception if notmuch_database_close or notmuch_database_destroy
+> fail.
+> ---
+>  bindings/python/notmuch/database.py | 12 ++++++++----
+>  1 file changed, 8 insertions(+), 4 deletions(-)
+>
+
+I don't really feel qualified to review changes to the python bindings.
+Justus, are you still following/mainting the python bindings? If so,
+what do you think of this patch?
+
+d