From: Mark Walters Date: Sat, 18 Jan 2014 23:30:48 +0000 (+0000) Subject: [PATCH 0/7] emacs: show tag changes in buffer X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=db9b2bdffaf13790c56941d982fcb40f75d55359;p=notmuch-archives.git [PATCH 0/7] emacs: show tag changes in buffer --- diff --git a/67/689e629906c4e47a6cda70bb856ad36989a647 b/67/689e629906c4e47a6cda70bb856ad36989a647 new file mode 100644 index 000000000..68ac176b6 --- /dev/null +++ b/67/689e629906c4e47a6cda70bb856ad36989a647 @@ -0,0 +1,115 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id A719E431FC7 + for ; Sat, 18 Jan 2014 15:31:11 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 2.7 +X-Spam-Level: ** +X-Spam-Status: No, score=2.7 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001, + FREEMAIL_REPLY=2.499, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id v5nT0ZasUXq7 for ; + Sat, 18 Jan 2014 15:31:06 -0800 (PST) +Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com + [209.85.212.170]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 03760431FBC + for ; Sat, 18 Jan 2014 15:31:05 -0800 (PST) +Received: by mail-wi0-f170.google.com with SMTP id ex4so3294269wid.3 + for ; Sat, 18 Jan 2014 15:31:03 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:cc:subject:date:message-id; + bh=WNbGC0cAN6FbhlSHBk/QDu8eT1VeBKkbAWd4A1o/t40=; + b=NV8L5rcF09ULrOTug9GOGaP7wjQJgOs1tzRcGMyXpoSr5ZYOFJPcxM709TkPCtbTmu + pKRSTJ7NerW9FSJtCnAay3bh8hYp7Y5t8ESVReZvhExcsEcRRkqCdy+dFa4uj3AQSbaQ + 6nWTH95RY1HT29n1x5Ls+ZD6M7BtKLLMCCXHLPNH57/Pl90lpiJGU40O9fZksJCTFFvU + YTOb7Ktb8oCmREeuju09Xu4CkhrOq/WGbiH7qZW88Vy3sBqsivHBZBOhRq9XYPCdKizE + HBM1eNnN+eYCmN4lKL7ALEJuznTbmWK2otIMtqBCF12SAFl+KF15q7DyBtYJQ+EmJAzS + RYXQ== +X-Received: by 10.180.189.106 with SMTP id gh10mr4154275wic.18.1390087861988; + Sat, 18 Jan 2014 15:31:01 -0800 (PST) +Received: from localhost (93-97-24-31.zone5.bethere.co.uk. [93.97.24.31]) + by mx.google.com with ESMTPSA id z1sm4198841wjq.19.2014.01.18.15.31.01 + for + (version=TLSv1.2 cipher=RC4-SHA bits=128/128); + Sat, 18 Jan 2014 15:31:01 -0800 (PST) +From: Mark Walters +To: notmuch@notmuchmail.org +Subject: [PATCH 0/7] emacs: show tag changes in buffer +Date: Sat, 18 Jan 2014 23:30:48 +0000 +Message-Id: <1390087855-26194-1-git-send-email-markwalters1009@gmail.com> +X-Mailer: git-send-email 1.7.9.1 +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 18 Jan 2014 23:31:11 -0000 + +This is a reworked and expanded version of the single patch +id:1387065197-15776-4-git-send-email-markwalters1009@gmail.com + +This shows any tags changed in the show buffer since it was loaded or +refreshed. By default a removed tag is displayed with strike-through +in red (if strike-through is not available, eg on a terminal, inverse +video is used instead) and an added tag is displayed underlined in +green. This version works in all three views show, search and tree. + +My motivation for this is part of a rework of the unread handling: we +can do a lot more automatically if we make it clear to the user what +we have done (which this does). It also make automatic updating of +buffers on tag-changes such as the search buffer showing tag changes +done in the show buffer a sensible possibility (as the user does not +lose information) + +The patch series is large but I have tried to split it up into small pieces + +Patches 1-3 are preparation mostly adding defcustoms for the format +for added or deleted tags. + +Patch 4 does all the actual logic to allow added and deleted tags to be shown. + +Patches 5-7 make show/search and tree keep track of the original tags +to use the functionality in Patch 4. + +I have been running this series (with the unread and auto-updating +described above) for about a month and it seems to work well for my use. + +Best wishes + +Mark + + + +Mark Walters (7): + emacs: tag split customise option for format-tags into a widget + emacs: tag: allow default case in notmuch-tag-formats + emacs: tag: add customize for deleted/added tag formats + emacs: show: mark tags changed since buffer loaded + emacs: show: use orig-tags for tag display + emacs: search: use orig-tags in search + emacs: tree: use orig-tags in search + + emacs/notmuch-show.el | 6 ++- + emacs/notmuch-tag.el | 116 ++++++++++++++++++++++++++++++++++-------------- + emacs/notmuch-tree.el | 9 +++- + emacs/notmuch.el | 12 ++++- + test/test-lib.el | 4 ++ + 5 files changed, 105 insertions(+), 42 deletions(-) + +-- +1.7.9.1 +