From: Joey Hess Date: Wed, 17 Sep 2008 18:34:02 +0000 (-0400) Subject: editdiff: Broken since 2.62 due to wrong syntax, now fixed. X-Git-Tag: 2.65~100 X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=da7c6eb1b40de8ca02a2d36dff3da24e43977490;p=ikiwiki.git editdiff: Broken since 2.62 due to wrong syntax, now fixed. --- diff --git a/IkiWiki/Plugin/editdiff.pm b/IkiWiki/Plugin/editdiff.pm index 2b1fac55d..f5d7837fc 100644 --- a/IkiWiki/Plugin/editdiff.pm +++ b/IkiWiki/Plugin/editdiff.pm @@ -56,7 +56,7 @@ sub formbuilder_setup { #{{{ my %params=@_; my $form=$params{form}; - return if defined ! $form->field("do") || $form->field("do") ne "edit"; + return if ! defined $form->field("do") || $form->field("do") ne "edit"; my $page=$form->field("page"); $page = IkiWiki::possibly_foolish_untaint($page); diff --git a/debian/changelog b/debian/changelog index 611138cb8..b05e8390b 100644 --- a/debian/changelog +++ b/debian/changelog @@ -2,6 +2,7 @@ ikiwiki (2.65) UNRELEASED; urgency=low * aggregate: Allow expirecount to work on the first pass. (expireage still needs to wait for the pages to be rendered though) + * editdiff: Broken since 2.62 due to wrong syntax, now fixed. -- Joey Hess Wed, 17 Sep 2008 14:26:56 -0400 diff --git a/doc/plugins/editdiff/discussion.mdwn b/doc/plugins/editdiff/discussion.mdwn index 8a1a59f79..386a4ba5b 100644 --- a/doc/plugins/editdiff/discussion.mdwn +++ b/doc/plugins/editdiff/discussion.mdwn @@ -1 +1,3 @@ I've enabled the plugin on an SVN-backed wiki, but am not seeing the Diff button when editing. (I do see the Rename and Remove buttons from having enabled those plugins.) Any ideas why it wouldn't be showing up? --[[schmonz]] + +> It was broken, I've fixed it. --[[Joey]]