From: David Bremner Date: Tue, 28 Oct 2014 20:56:46 +0000 (+0100) Subject: Re: [PATCH] test: fix test_require_external_prereq gdb in insert test X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=d99f05fcbebfec6337b673a3666600fedc844fc2;p=notmuch-archives.git Re: [PATCH] test: fix test_require_external_prereq gdb in insert test --- diff --git a/76/8361a6e5bc485d69fd6ae7c1fe659da4930065 b/76/8361a6e5bc485d69fd6ae7c1fe659da4930065 new file mode 100644 index 000000000..02561cbad --- /dev/null +++ b/76/8361a6e5bc485d69fd6ae7c1fe659da4930065 @@ -0,0 +1,85 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 18A83431FBF + for ; Tue, 28 Oct 2014 13:57:01 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id yvJ9FgB-SU+w for ; + Tue, 28 Oct 2014 13:56:53 -0700 (PDT) +Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 13F83431FB6 + for ; Tue, 28 Oct 2014 13:56:53 -0700 (PDT) +Received: from remotemail by yantan.tethera.net with local (Exim 4.80) + (envelope-from ) + id 1XjDox-0003db-UB; Tue, 28 Oct 2014 17:56:51 -0300 +Received: (nullmailer pid 2918 invoked by uid 1000); Tue, 28 Oct 2014 + 20:56:46 -0000 +From: David Bremner +To: Jani Nikula , notmuch@notmuchmail.org +Subject: Re: [PATCH] test: fix test_require_external_prereq gdb in insert test +In-Reply-To: <877fzk0ylr.fsf@nikula.org> +References: <1414518754-16344-1-git-send-email-jani@nikula.org> + <87a94g2h7t.fsf@maritornes.cs.unb.ca> <877fzk0ylr.fsf@nikula.org> +User-Agent: Notmuch/0.18.1+131~gdd8373f (http://notmuchmail.org) Emacs/24.4.1 + (x86_64-pc-linux-gnu) +Date: Tue, 28 Oct 2014 21:56:46 +0100 +Message-ID: <87y4rz29rl.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 28 Oct 2014 20:57:01 -0000 + +Jani Nikula writes: + + +>> Of course you're right that moving it forward to only skip the gdb +>> requiring tests is the right thing to do, and in that setting having a +>> skipped message for all 10 skipped tests is a bit ugly. OTOHO your +>> version doesn't give any output at all, which seems not perfect either. +> +> How does it work if you just move the prereq test forward? +> + +Then we get one message per skipped test. So twenty lines it total. + + missing prerequisites: gdb(1) + SKIP error exit when add_message returns OUT_OF_MEMORY + missing prerequisites: gdb(1) + SKIP success exit with --keep when add_message returns OUT_OF_MEMORY + missing prerequisites: gdb(1) + SKIP error exit when add_message returns XAPIAN_EXCEPTION + missing prerequisites: gdb(1) + SKIP success exit with --keep when add_message returns XAPIAN_EXCEPTION + missing prerequisites: gdb(1) + SKIP error exit when add_message returns FILE_NOT_EMAIL + missing prerequisites: gdb(1) + SKIP success exit with --keep when add_message returns FILE_NOT_EMAIL + missing prerequisites: gdb(1) + SKIP error exit when add_message returns READ_ONLY_DATABASE + missing prerequisites: gdb(1) + SKIP success exit with --keep when add_message returns READ_ONLY_DATABASE + missing prerequisites: gdb(1) + SKIP error exit when add_message returns UPGRADE_REQUIRED + missing prerequisites: gdb(1) + SKIP success exit with --keep when add_message returns UPGRADE_REQUIRED