From: Zac Medico <zmedico@gentoo.org>
Date: Mon, 6 Jun 2011 02:01:02 +0000 (-0700)
Subject: InternalPackageSet: default allow_repo=True
X-Git-Tag: v2.2.0_alpha38~7
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=d90686c6b2dff96b883f6e1038e228d2b8351660;p=portage.git

InternalPackageSet: default allow_repo=True

Repo atoms are allowed more often than not, so it makes sense for this
class to allow them by default. The Atom constructor and isvalidatom()
functions default to allow_repo=False, which is sufficient to ensure
that repo atoms are prohibited when necessary.
---

diff --git a/pym/portage/_sets/base.py b/pym/portage/_sets/base.py
index b3bb06b4c..c8d3ae405 100644
--- a/pym/portage/_sets/base.py
+++ b/pym/portage/_sets/base.py
@@ -1,4 +1,4 @@
-# Copyright 2007-2010 Gentoo Foundation
+# Copyright 2007-2011 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
 
 import sys
@@ -228,7 +228,13 @@ class EditablePackageSet(PackageSet):
 		raise NotImplementedError()
 
 class InternalPackageSet(EditablePackageSet):
-	def __init__(self, initial_atoms=None, allow_wildcard=False, allow_repo=False):
+	def __init__(self, initial_atoms=None, allow_wildcard=False, allow_repo=True):
+		"""
+		Repo atoms are allowed more often than not, so it makes sense for this
+		class to allow them by default. The Atom constructor and isvalidatom()
+		functions default to allow_repo=False, which is sufficient to ensure
+		that repo atoms are prohibited when necessary.
+		"""
 		super(InternalPackageSet, self).__init__(allow_wildcard=allow_wildcard, allow_repo=allow_repo)
 		if initial_atoms != None:
 			self.update(initial_atoms)