From: Jeffrey Altman <jaltman@secure-endpoints.com>
Date: Fri, 24 Aug 2007 14:20:31 +0000 (+0000)
Subject: NIM: resource leak in khui_action_trigger()
X-Git-Tag: krb5-1.7-alpha1~946
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=d8daba5d488be9b24fdbaca2272553818735ce99;p=krb5.git

NIM: resource leak in khui_action_trigger()

The khui_action_trigger() function in the Network Identity Manager API
creates a copy of the current user interface context (which contains
information about the credentials and identities that are currently
selected) before triggering the requested action.  Then it will use
the copy to restore the user interface context to its previous state.
A coding error results in the copy of the context to never be
released.  As a result there is a resource leak.

The attached patch fixes the leak by releasing the context once it
is no longer needed.

ticket: new
component: windows

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19852 dc483132-0cff-0310-8789-dd5450dbe970
---

diff --git a/src/windows/identity/uilib/action.c b/src/windows/identity/uilib/action.c
index be3860c81..3476428ac 100644
--- a/src/windows/identity/uilib/action.c
+++ b/src/windows/identity/uilib/action.c
@@ -497,6 +497,7 @@ khui_action_trigger(khm_int32 action, khui_action_context * ctx) {
 
     if (ctx) {
 	khui_context_set_indirect(&save);
+        khui_context_release(&save);
     }
 }