From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Fri, 6 Nov 2015 15:31:38 +0000 (+0200)
Subject: Re: [PATCH] emacs: Fontify From with message-header-other
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=d84ac875b295181973e0ee98efe0b764ba0f56e6;p=notmuch-archives.git

Re: [PATCH] emacs: Fontify From with message-header-other
---

diff --git a/3c/4098cebce55a7735c0b60062dbce415c407dbb b/3c/4098cebce55a7735c0b60062dbce415c407dbb
new file mode 100644
index 000000000..101410f31
--- /dev/null
+++ b/3c/4098cebce55a7735c0b60062dbce415c407dbb
@@ -0,0 +1,98 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+ by arlo.cworth.org (Postfix) with ESMTP id 6864E6DE1744
+ for <notmuch@notmuchmail.org>; Fri,  6 Nov 2015 07:31:41 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at cworth.org
+X-Spam-Flag: NO
+X-Spam-Score: 0.733
+X-Spam-Level: 
+X-Spam-Status: No, score=0.733 tagged_above=-999 required=5 tests=[AWL=0.081, 
+ SPF_NEUTRAL=0.652] autolearn=disabled
+Received: from arlo.cworth.org ([127.0.0.1])
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
+ with ESMTP id k4o80773mhQq for <notmuch@notmuchmail.org>;
+ Fri,  6 Nov 2015 07:31:39 -0800 (PST)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+ by arlo.cworth.org (Postfix) with ESMTP id 1209A6DE1502
+ for <notmuch@notmuchmail.org>; Fri,  6 Nov 2015 07:31:39 -0800 (PST)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+ by guru.guru-group.fi (Postfix) with ESMTP id 3EBAB10005A;
+ Fri,  6 Nov 2015 17:31:39 +0200 (EET)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: "H. J. Illikainen" <hji@dyntopia.com>, notmuch@notmuchmail.org
+Subject: Re: [PATCH] emacs: Fontify From with message-header-other
+In-Reply-To: <1446677040-43496-1-git-send-email-hji@dyntopia.com>
+References: <1446677040-43496-1-git-send-email-hji@dyntopia.com>
+User-Agent: Notmuch/0.21+14~g053baf4 (http://notmuchmail.org) Emacs/24.3.1
+ (x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Fri, 06 Nov 2015 17:31:38 +0200
+Message-ID: <m2lhab87qd.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.20
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+ <notmuch.notmuchmail.org>
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Fri, 06 Nov 2015 15:31:41 -0000
+
+On Thu, Nov 05 2015, "H. J. Illikainen" <hji@dyntopia.com> wrote:
+
+> Commit e26d767897e8ab59f05808a12ac5c9c1e3c7030f changed the
+> fontification of the body associated with the From header to
+> message-header-from.  However, that face is non-existent, and in
+> message.el (message-font-lock-keywords) the From-header falls through
+> and is attributed the message-header-other face.
+>
+> This commit removes the fontification of the [Ff]rom header in
+> notmuch-show-mode in order to fontify it using the message-header-other
+> face.
+>
+> This only affects non-default configurations where
+> notmuch-message-headers is set to display From.
+
+I grepped emacs 24.3 sources for message-header-subject and
+message-header-from and, indeed, there is not reference to 
+message-header-from (but plenty of message-header-subject).
+
+So, to me this change looks good (and trivial) -- I have not
+tested it (yet), though.
+
+Tomi
+
+> ---
+>  emacs/notmuch-show.el | 2 --
+>  1 file changed, 2 deletions(-)
+>
+> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
+> index 49fd198..793f1a5 100644
+> --- a/emacs/notmuch-show.el
+> +++ b/emacs/notmuch-show.el
+> @@ -353,8 +353,6 @@ operation on the contents of the current buffer."
+>  		'message-header-cc)
+>  	       ((looking-at "[Ss]ubject:")
+>  		'message-header-subject)
+> -	       ((looking-at "[Ff]rom:")
+> -		'message-header-from)
+>  	       (t
+>  		'message-header-other))))
+>  
+> -- 
+> H. J. Illikainen
+>
+> _______________________________________________
+> notmuch mailing list
+> notmuch@notmuchmail.org
+> https://notmuchmail.org/mailman/listinfo/notmuch