From: Ian Main Date: Wed, 15 Oct 2014 19:33:55 +0000 (+1700) Subject: Re: [PATCH] VIM: Add URI handling X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=d7a57d31e8bf2bf974976ccbba7c6982df4537dd;p=notmuch-archives.git Re: [PATCH] VIM: Add URI handling --- diff --git a/12/ddd2c098282ab28a6eb9e4551bdf9a24e2aa15 b/12/ddd2c098282ab28a6eb9e4551bdf9a24e2aa15 new file mode 100644 index 000000000..0dce9e962 --- /dev/null +++ b/12/ddd2c098282ab28a6eb9e4551bdf9a24e2aa15 @@ -0,0 +1,183 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 4E0A7431FB6 + for ; Wed, 15 Oct 2014 12:34:03 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id d3AYF5s1z9U1 for ; + Wed, 15 Oct 2014 12:33:59 -0700 (PDT) +Received: from cmta10.telus.net (cmta10.telus.net [209.171.16.83]) + by olra.theworths.org (Postfix) with ESMTP id 5B1B6431FAF + for ; Wed, 15 Oct 2014 12:33:59 -0700 (PDT) +Received: from ovo.mains.priv ([207.102.88.62]) by cmta10.telus.net with TELUS + id 3XZy1p00D1LiWEf01XZyoQ; Wed, 15 Oct 2014 13:33:58 -0600 +X-Authority-Analysis: v=2.0 cv=PP7RD4WC c=1 sm=2 + a=EcQDfIwDZEqJA1f7rVUV8Q==:17 a=S-IsBHyFrF4A:10 a=IkcTkHD0fZMA:10 + a=tsa3CZZnAAAA:8 a=XWforfwaZwZkm9eP2S4A:9 a=QEXdDO2ut3YA:10 + a=P87eogJZi2UA:10 a=EcQDfIwDZEqJA1f7rVUV8Q==:117 +X-Telus-Outbound-IP: 207.102.88.62 +Received: from ovo.mains.priv (localhost.localdomain [127.0.0.1]) + by ovo.mains.priv (8.14.8/8.14.8) with ESMTP id s9FJXu0b011335; + Wed, 15 Oct 2014 12:33:56 -0700 +Received: (from imain@localhost) + by ovo.mains.priv (8.14.8/8.14.8/Submit) id s9FJXtMY011334; + Wed, 15 Oct 2014 12:33:55 -0700 +X-Authentication-Warning: ovo.mains.priv: imain set sender to imain@redhat.com + using -f +Date: Wed, 15 Oct 2014 12:33:55 -0700 +From: Ian Main +To: Franz Fellner +Message-ID: <543ecc23bb98_2c291569e8c17@ovo.mains.priv.notmuch> +In-Reply-To: <20141011142943.GD23373@TP_L520.localdomain> +References: <1412281423-22441-1-git-send-email-imain@stemwinder.org> + <20141010114457.GG28601@TP_L520.localdomain> + <543822f73d3fd_46ad163fe88cd@ovo.mains.priv.notmuch> + <20141011142943.GD23373@TP_L520.localdomain> +Subject: Re: [PATCH] VIM: Add URI handling +Mime-Version: 1.0 +Content-Type: text/plain; + charset=utf-8 +Content-Transfer-Encoding: 7bit +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 15 Oct 2014 19:34:03 -0000 + +Franz Fellner wrote: +> Here is a working implementation. +> Please review carefully as I only can simulate ruby and vimscript +> knowledge from what I see in notmuch.vim sourcefile and quick +> googling. + +Yes, this works nicely. Thanks! + +I do notice however that this is against the github plugin repo (I think)? + +I think It'd be nice to have this against the main repo and in its own +thread. I can repost it for you if you like as I added it to mine, or you +can do it if you prefer. + + Ian + +> Regards +> Franz +> +> +> diff --git a/plugin/notmuch.vim b/plugin/notmuch.vim +> index 567f75c..ef9fefa 100644 +> --- a/plugin/notmuch.vim +> +++ b/plugin/notmuch.vim +> @@ -269,6 +269,14 @@ ruby << EOF +> if uri.class == URI::MailTo +> vim_puts("Composing new email to #{uri.to}.") +> VIM::command("call s:compose('#{uri.to}')") +> + elsif uri.class == URI::MsgID +> + msg = $curbuf.message(uri.opaque) +> + if !msg +> + vim_puts("Message not found in NotMuch database: #{uri.to_s}") +> + else +> + vim_puts("Opening message #{msg.message_id} in thread #{msg.thread_id}.") +> + VIM::command("call s:show('thread:#{msg.thread_id}', '#{msg.message_id}')") +> + end +> else +> vim_puts("Opening #{uri.to_s}.") +> cmd = VIM::evaluate('g:notmuch_open_uri') +> @@ -429,11 +437,12 @@ endfunction +> +> "" main +> +> -function! s:show(thread_id) +> +function! s:show(thread_id, msg_id) +> call s:new_buffer('show') +> setlocal modifiable +> ruby << EOF +> thread_id = VIM::evaluate('a:thread_id') +> + msg_id = VIM::evaluate('a:msg_id') +> $cur_thread = thread_id +> $messages.clear +> $curbuf.render do |b| +> @@ -465,6 +474,9 @@ ruby << EOF +> end +> b << "" +> nm_m.end = b.count +> + if msg_id and nm_m.message_id == msg_id +> + VIM::command("normal #{nm_m.start}zt") +> + end +> end +> b.delete(b.count) +> end +> @@ -487,7 +499,7 @@ ruby << EOF +> when 1; $cur_filter = nil +> when 2; $cur_filter = $cur_search +> end +> - VIM::command("call s:show('#{id}')") +> + VIM::command("call s:show('#{id}', '')") +> EOF +> endfunction +> +> @@ -917,6 +929,10 @@ ruby << EOF +> q +> end +> +> + def message(id) +> + @db.find_message(id) +> + end +> + +> def close +> @queries.delete_if { |q| ! q.destroy! } +> @db.close +> @@ -937,12 +953,20 @@ ruby << EOF +> end +> end +> +> + module URI +> + class MsgID < Generic +> + end +> + +> + @@schemes['ID'] = MsgID +> + end +> + +> class Message +> attr_accessor :start, :body_start, :end +> - attr_reader :message_id, :filename, :mail +> + attr_reader :message_id, :thread_id, :filename, :mail +> +> def initialize(msg, mail) +> @message_id = msg.message_id +> + @thread_id = msg.thread_id +> @filename = msg.filename +> @mail = mail +> @start = 0 +> +> On Fri, 10 Oct 2014 11:18:31 -0700, Ian Main wrote: +> > Franz Fellner wrote: +> > > Works nice. Tested with an https and a mailto URI. +> > > But it would be awesome if you could add message id handling, So one +> > > could easily navigate to linked messages. I only found emacs client +> > > implement this feature. What I read in the docs about ruby URI module +> > > it should be fairly easy to add a custom scheme for id. +> > +> > I'm afraid I'm not sure what you mean by message id handling? It's +> > probably something simple but .. :) +> > +> > Ian + +