From: David Bremner Date: Sun, 5 Apr 2015 21:34:52 +0000 (+0900) Subject: Re: [PATCH 4/4] cli: add standard option processing to config and setup X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=d7707518e1ea77ce659386b62cc2c0715dc9cb33;p=notmuch-archives.git Re: [PATCH 4/4] cli: add standard option processing to config and setup --- diff --git a/0c/f0f1c30f47bdc1e5c8c725c5245c2bff834131 b/0c/f0f1c30f47bdc1e5c8c725c5245c2bff834131 new file mode 100644 index 000000000..2f9ba948e --- /dev/null +++ b/0c/f0f1c30f47bdc1e5c8c725c5245c2bff834131 @@ -0,0 +1,77 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 43E066DE1B5C + for ; Sun, 5 Apr 2015 14:35:44 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 0.602 +X-Spam-Level: +X-Spam-Status: No, score=0.602 tagged_above=-999 required=5 tests=[AWL=0.602] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id dfGQiBSS8be4 for ; + Sun, 5 Apr 2015 14:35:41 -0700 (PDT) +Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net + [87.98.215.224]) + by arlo.cworth.org (Postfix) with ESMTPS id 928DB6DE1997 + for ; Sun, 5 Apr 2015 14:35:41 -0700 (PDT) +Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim + 4.80) (envelope-from ) + id 1YesCD-0002Ys-M3; Sun, 05 Apr 2015 21:35:09 +0000 +Received: (nullmailer pid 19461 invoked by uid 1000); Sun, 05 Apr 2015 + 21:34:52 -0000 +From: David Bremner +To: notmuch@notmuchmail.org +Subject: Re: [PATCH 4/4] cli: add standard option processing to config and + setup +In-Reply-To: <1428267574-28797-5-git-send-email-david@tethera.net> +References: <1428267574-28797-1-git-send-email-david@tethera.net> + <1428267574-28797-5-git-send-email-david@tethera.net> +User-Agent: Notmuch/0.19+96~g703c8f9 (http://notmuchmail.org) Emacs/24.4.1 + (x86_64-pc-linux-gnu) +Date: Mon, 06 Apr 2015 06:34:52 +0900 +Message-ID: <87d23ixnr7.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.18 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 05 Apr 2015 21:35:44 -0000 + +David Bremner writes: + +> In particular this fixes a recently encountered bug where the +> "--config" argument to "notmuch setup" is silently ignored, which the +> unpleasant consequence of overwriting the users config file. + +Urgh. I had a longish cover letter for this series but somehow mashing +buttons with git-send-email caused it to be lost forever. Or maybe it's +en route still. Anyway, here is a quick summary: + +- The first two patches are worthwhile just to improve understandability + IMHO + +- The third patch is a bit big for tiny improvement in functionality, + but it does make it easier to define global arguments, which is + something I want for the revision-tracking series + (id:1413181203-1676-1-git-send-email-aclements@csail.mit.edu) + +- the last patch fixes an annoying bug where --config is silently + ignored in + + % notmuch setup --config=foobar + + This could of course be fixed in a way that doesn't depend on patch + 3/4.