From: Michal Sojka Date: Wed, 6 Jan 2016 21:28:45 +0000 (+0100) Subject: [PATCH] emacs: Don't use nconc on quoted list X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=d7707438480b71c704653bc12ad6bf604353fcd5;p=notmuch-archives.git [PATCH] emacs: Don't use nconc on quoted list --- diff --git a/4d/50c079ded3986e4a7ae577364fed03d9feac0d b/4d/50c079ded3986e4a7ae577364fed03d9feac0d new file mode 100644 index 000000000..0cd49bf01 --- /dev/null +++ b/4d/50c079ded3986e4a7ae577364fed03d9feac0d @@ -0,0 +1,84 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 0FD0B6DE103A + for ; Wed, 6 Jan 2016 13:29:01 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -1.849 +X-Spam-Level: +X-Spam-Status: No, score=-1.849 tagged_above=-999 required=5 tests=[AWL=1.021, + RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, + RP_MATCHES_RCVD=-0.55] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id oeEbn6UWq7UA for ; + Wed, 6 Jan 2016 13:28:59 -0800 (PST) +Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36]) + by arlo.cworth.org (Postfix) with ESMTP id 2D7396DE1003 + for ; Wed, 6 Jan 2016 13:28:59 -0800 (PST) +Received: from localhost (unknown [192.168.200.7]) + by max.feld.cvut.cz (Postfix) with ESMTP id 7688519F4644; + Wed, 6 Jan 2016 22:28:58 +0100 (CET) +X-Virus-Scanned: IMAP STYX AMAVIS +Received: from max.feld.cvut.cz ([192.168.200.1]) + by localhost (styx.feld.cvut.cz [192.168.200.7]) (amavisd-new, port 10044) + with ESMTP id hV_iw7wpqROL; Wed, 6 Jan 2016 22:28:56 +0100 (CET) +Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34]) + by max.feld.cvut.cz (Postfix) with ESMTP id D6A2519F41E2; + Wed, 6 Jan 2016 22:28:56 +0100 (CET) +Received: from wsh by steelpick.2x.cz with local (Exim 4.86) + (envelope-from ) + id 1aGvdY-00057g-Fi; Wed, 06 Jan 2016 22:28:56 +0100 +From: Michal Sojka +To: David Bremner , + notmuch@notmuchmail.org +Subject: [PATCH] emacs: Don't use nconc on quoted list +Date: Wed, 6 Jan 2016 22:28:45 +0100 +Message-Id: <1452115725-19650-1-git-send-email-sojkam1@fel.cvut.cz> +X-Mailer: git-send-email 2.6.4 +In-Reply-To: <87ziwiv1nx.fsf@steelpick.2x.cz> +References: <87ziwiv1nx.fsf@steelpick.2x.cz> +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 06 Jan 2016 21:29:01 -0000 + +As pointed out by David Bremner, Elisp manual says "A common pitfall +is to use a quoted constant list as a non-last argument to ‘nconc’." +Since this was the case in recently added code, we fix it here. +--- + emacs/notmuch-mua.el | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el +index 45a6daa..5462f54 100644 +--- a/emacs/notmuch-mua.el ++++ b/emacs/notmuch-mua.el +@@ -322,8 +322,8 @@ modified. This function is notmuch addaptation of + (notmuch-mua-pop-to-buffer (message-buffer-name "mail" to) + (or switch-function (notmuch-mua-get-switch-function))) + (let ((headers +- ;; The following sexp is copied from `message-mail' +- (nconc ++ (append ++ ;; The following is copied from `message-mail' + `((To . ,(or to "")) (Subject . ,(or subject ""))) + ;; C-h f compose-mail says that headers should be specified as + ;; (string . value); however all the rest of message expects +-- +2.6.4 +