From: Paul Mackerras <paulus@samba.org>
Date: Fri, 7 Mar 2008 10:19:18 +0000 (+1100)
Subject: gitk: Avoid a crash in selectline if commitinfo($id) isn't set
X-Git-Tag: v1.5.6-rc0~20^2~11
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=d76afb15ada0e9e29cae2d83cd35d9489a042b0c;p=git.git

gitk: Avoid a crash in selectline if commitinfo($id) isn't set

Occasionally I see a crash in selectline with commitinfo($id) not
set.  This makes sure it is set by calling getcommit $id if it isn't.

Signed-off-by: Paul Mackerras <paulus@samba.org>
---

diff --git a/gitk b/gitk
index f2ebc600e..19325086b 100755
--- a/gitk
+++ b/gitk
@@ -1218,7 +1218,7 @@ proc chewcommits {} {
     if {$viewcomplete($curview)} {
 	global commitidx varctok
 	global numcommits startmsecs
-	global mainheadid commitinfo nullid
+	global mainheadid nullid
 
 	if {[info exists pending_select]} {
 	    set row [first_real_row]
@@ -5494,6 +5494,9 @@ proc selectline {l isnew} {
     $ctext conf -state normal
     clear_ctext
     set linknum 0
+    if {![info exists commitinfo($id)]} {
+	getcommit $id
+    }
     set info $commitinfo($id)
     set date [formatdate [lindex $info 2]]
     $ctext insert end "[mc "Author"]: [lindex $info 1]  $date\n"