From: Fraser Tweedale Date: Wed, 21 May 2014 09:13:05 +0000 (+1000) Subject: Re: [PATCH 1/2] configure: add a fallback check for zlib X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=d75ebca91807351be8453427d0aba3cc463adea6;p=notmuch-archives.git Re: [PATCH 1/2] configure: add a fallback check for zlib --- diff --git a/9f/7f2fba7cd25843b66202eaf9b92bad4581dcd6 b/9f/7f2fba7cd25843b66202eaf9b92bad4581dcd6 new file mode 100644 index 000000000..de4cd1d1e --- /dev/null +++ b/9f/7f2fba7cd25843b66202eaf9b92bad4581dcd6 @@ -0,0 +1,146 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 127AC431FC7 + for ; Wed, 21 May 2014 02:45:27 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 3HLgFA9-TaIv for ; + Wed, 21 May 2014 02:45:23 -0700 (PDT) +Received: from captainmorgan.hollandpark.frase.id.au + (110-174-235-130.static.tpgi.com.au [110.174.235.130]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 938FD431FC4 + for ; Wed, 21 May 2014 02:45:22 -0700 (PDT) +Received: from bacardi.hollandpark.frase.id.au + (bacardi.hollandpark.frase.id.au [192.168.0.100]) + by captainmorgan.hollandpark.frase.id.au (8.14.5/8.14.5) with ESMTP id + s4L9D61N023263 + for ; Wed, 21 May 2014 19:13:06 +1000 (EST) + (envelope-from frase@frase.id.au) +Received: from bacardi.hollandpark.frase.id.au (localhost [127.0.0.1]) + by bacardi.hollandpark.frase.id.au (8.14.7/8.14.7) with ESMTP id + s4L9D6JU073986 + (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 + verify=NO) + for ; Wed, 21 May 2014 19:13:06 +1000 (EST) + (envelope-from frase@frase.id.au) +Received: (from fraser@localhost) + by bacardi.hollandpark.frase.id.au (8.14.7/8.14.7/Submit) id + s4L9D5HY073985 + for notmuch@notmuchmail.org; Wed, 21 May 2014 19:13:05 +1000 (EST) + (envelope-from frase@frase.id.au) +X-Authentication-Warning: bacardi.hollandpark.frase.id.au: fraser set sender + to frase@frase.id.au using -f +Date: Wed, 21 May 2014 19:13:05 +1000 +From: Fraser Tweedale +To: notmuch@notmuchmail.org +Subject: Re: [PATCH 1/2] configure: add a fallback check for zlib +Message-ID: <20140521091304.GT62147@bacardi.hollandpark.frase.id.au> +References: <1399753646-3026-1-git-send-email-xico@atelo.org> + <536e965c9415e_300d7772fc9@nysa.notmuch> + + <536ea7d6a4c86_3c5a8eb3048b@nysa.notmuch> +MIME-Version: 1.0 +Content-Type: multipart/signed; micalg=pgp-sha1; + protocol="application/pgp-signature"; boundary="LZFKeWUZP29EKQNE" +Content-Disposition: inline +In-Reply-To: <536ea7d6a4c86_3c5a8eb3048b@nysa.notmuch> +User-Agent: Mutt/1.5.23 (2014-03-12) +X-Mailman-Approved-At: Wed, 21 May 2014 12:30:39 -0700 +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 21 May 2014 09:45:27 -0000 + + +--LZFKeWUZP29EKQNE +Content-Type: text/plain; charset=utf-8 +Content-Disposition: inline +Content-Transfer-Encoding: quoted-printable + +On Sat, May 10, 2014 at 05:27:34PM -0500, Felipe Contreras wrote: +> Tomi Ollila wrote: +> > On Sun, May 11 2014, Felipe Contreras wrot= +e: +> >=20 +> > > X=C4=ABc=C3=B2 wrote: +> > >> Since zlib is part of the base system, FreeBSD chose not to register= + it +> > >> in pkg-config through zlib.pc. As a fallback test, configure will bu= +ild +> > >> and run a zlib version check and make sure the header and library +> > >> versions are compatible. +> > > +> > > We could try to generate our on zlib.pc, this way the configure script +> > > would be cleaner. +> >=20 +> > But for that we'd need to figure out the version, and is there simpler +> > robust way to do that some other way ? +>=20 +> I don't meant to change the code that is checking for the version in the +> patch, you use the same code, but instead of have_zlib.c gen_zlib_pc.c, +> or something. +>=20 + +[please cc me in replies; I am not subscribed to the list] + +I think that the additional complexity outweighs the benefit of a +somewhat cleaner build script. + +If the $vz1, $vz2, et al. are what's bothering you, perhaps we could +push the complexity of version comparison into have_zlib.c and +supply the (string) version number as an argument to the program. +The have_zlib program could do the comparison and exit accordingly, +and plain old "1.2.5.2" can take its place in the configure script +once more. + +However, I don't see any problems with the patch as it is; I have +tested it on FreeBSD 10.0 and it works. + +Regards, + +Fraser + +> --=20 +> Felipe Contreras + +--LZFKeWUZP29EKQNE +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v2.0.22 (FreeBSD) + +iQIcBAEBAgAGBQJTfG4gAAoJEEtTkFJBEeHicyAP/Ar2jAL/Gh6QI4J99sO9uGfJ +Xuxd9OQ2CKPLk0YaOl6lek2pqa9YHGZ86CyRT00JGIdrqHykPEawRbF1hpXLSzQb +aDbLYEnFKCBSk4kfdQX//5BM9ovSIe3krTwyJAKNysfL7iGLLDr6u8V00ExuHTVG +nCagnTaADOth3tl13mP7fYN9Q4Ye9TniVDMOBhSKFzMqzAohHK9dHerFXZGM76yx +hnJqM3Zao9XBo5Ow1Wu1k3snEKb+jCcMPg1zUncmIoYecxqJKIj9X0DMZ+Odwmw/ +250bbxu1OS/N6ffaitFnCWVvQLFJER8QvG6iErw3V0xpX9zmdF4H8Ans43T+eldT +WsWGtrIfoqkQuBCYlrNTog9rF8DBnB3vx5VsYaBW0vsoHH1faDz7BHy7w5dRVQuF +GxYPWV2HM38rbbZht42AsM8tI/uDp3nsWs7gd9N9+29pwFcy3kboSl0Wiff749BD +gwkM1D1QJmYpNqolMw0opu4kUeF4t2UJlhO7YQMReNIRNjjeqFjhAWmtWKGDMnwQ +ji4QOfCIzwMtc2LBvEpmEHKUtbfxrixruqVmLS8j2l2pRa8opgp955YQ1VYrVS0v +EIVFKQa3wl4wgiy+cRdOG2bfl74HgxxkYxhC9IJzq1Fbxgs2Zhydll4iSpThBJCu +5dpIBwpgZlzvisG0HObV +=41bM +-----END PGP SIGNATURE----- + +--LZFKeWUZP29EKQNE--