From: Tomi Ollila Date: Sun, 17 Nov 2013 19:42:40 +0000 (+0200) Subject: Re: [PATCH] emacs: do not put quoted reply in primary selection X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=d70edd2bba8a2fda91adb372ebf119fb0f8ca577;p=notmuch-archives.git Re: [PATCH] emacs: do not put quoted reply in primary selection --- diff --git a/e6/1df7c911a340d21170a68093d77203980dfaca b/e6/1df7c911a340d21170a68093d77203980dfaca new file mode 100644 index 000000000..edc193061 --- /dev/null +++ b/e6/1df7c911a340d21170a68093d77203980dfaca @@ -0,0 +1,89 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 445F1431FD4 + for ; Sun, 17 Nov 2013 11:42:52 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id RGcQgnavCfSy for ; + Sun, 17 Nov 2013 11:42:47 -0800 (PST) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 97A5A431FAF + for ; Sun, 17 Nov 2013 11:42:47 -0800 (PST) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 03245100030; + Sun, 17 Nov 2013 21:42:41 +0200 (EET) +From: Tomi Ollila +To: Jameson Graef Rollins , + Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: do not put quoted reply in primary selection +In-Reply-To: <87siuu95uy.fsf@servo.finestructure.net> +References: <1384689849-9388-1-git-send-email-markwalters1009@gmail.com> + <87siuu95uy.fsf@servo.finestructure.net> +User-Agent: Notmuch/0.16+175~g19e97d6 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 17 Nov 2013 19:42:52 -0000 + +On Sun, Nov 17 2013, Jameson Graef Rollins wrote: + +> On Sun, Nov 17 2013, Mark Walters wrote: +>> In current emacs (24.3) select-active-regions is set to t by +>> default. The reply insertion code sets the region to the quoted +>> message to make it easy to delete (kill-region or C-w). These two +>> things combine to put the quoted message in the primary selection. +>> +>> This is not what the user wanted and is a privacy risk (accidental +>> pasting of the quoted message). We can avoid some of the problems +>> by let-binding select-active-regions to nil. This fixes if the +>> primary selection was previously in a non-emacs window but not if +>> it was in an emacs window. To avoid the problem in the latter case +>> we deactivate mark. +>> +>> One key test (which fails under many simpler "fixes") is: open emacs +>> 24.3 with notmuch, open 2 windows (viewing different notmuch buffers), +>> highlight some text in one, and then reply to a message in the +>> other. In many of my earlier attempts to fix this big this test fails. +> +> I'm very happy to report that I reply to this message with an unpolluted +> paste buffer! Kudos Mark! +> +>> Anyway, this is the best I can manage! +> +> Too modest for such an achievement. +> +> +10 + +This works for me too (and tests pass). + +I don't see how this could break thinks, So I think this is important +enough th be included in 0.17 + +> jamie. + +Tomi