From: Tomi Ollila Date: Sun, 19 Oct 2014 10:02:28 +0000 (+0300) Subject: Re: [PATCH v3 3/4] cli: Extend the search command for --output={sender, recipients} X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=d6b44d064a0b630bdbb2a6fedf876543fb77bb72;p=notmuch-archives.git Re: [PATCH v3 3/4] cli: Extend the search command for --output={sender, recipients} --- diff --git a/c3/f9e9233a877705218b70118eeb796923cc968e b/c3/f9e9233a877705218b70118eeb796923cc968e new file mode 100644 index 000000000..56a9401c3 --- /dev/null +++ b/c3/f9e9233a877705218b70118eeb796923cc968e @@ -0,0 +1,90 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id C06FA431FC4 + for ; Sun, 19 Oct 2014 03:02:54 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id Pfsqy3ZjmJDL for ; + Sun, 19 Oct 2014 03:02:47 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id A6966431FBF + for ; Sun, 19 Oct 2014 03:02:47 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 8301F10008C; + Sun, 19 Oct 2014 13:02:28 +0300 (EEST) +From: Tomi Ollila +To: Michal Sojka , notmuch@notmuchmail.org +Subject: Re: [PATCH v3 3/4] cli: Extend the search command + for --output={sender, recipients} +In-Reply-To: <871tqbejl5.fsf@steelpick.2x.cz> +References: <87zjd51phx.fsf@steelpick.2x.cz> + <1413150093-8383-1-git-send-email-sojkam1@fel.cvut.cz> + <1413150093-8383-4-git-send-email-sojkam1@fel.cvut.cz> + + <871tqbejl5.fsf@steelpick.2x.cz> +User-Agent: Notmuch/0.18.1+130~ga61922f (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 19 Oct 2014 10:02:54 -0000 + + +Hi Michal, been busy lately so I haven't got into this... + +... I'll look into it in a bit more detail a bit later, + + +On Tue, Oct 14 2014, Michal Sojka wrote: + +> +> I don't know. You seem to think about this in the opposite way than how +> it is implemented. The implementation really filters things out whereas +> you specify what not to filter. +> +> My feeling is that if you would implement your proposal, the code would +> be more complex than in my patch, because the mapping between command +> line options and the actual algorithm would require some extra code. And +> in a previous comment, you preferred simplicity. + +Yes, maybe the choice of reusing --duplicate was bad, and perhaps took +thought from the main point -- what kind output options should be possible... + +> Hopefully, you consider the above as "healthy" criticism. + +Yes, I do -- I hope we can get something decent out in this in near future, +with duplicate filtering that can have useful options to be used directly +by MUAs and no duplicate filtering option which I can use in +nottoomuch-addresses in 2016 ;D + + + +> Thanks for quick review. +> -Michal + + +Tomi