From: David Bremner <david@tethera.net>
Date: Wed, 25 Mar 2015 16:47:06 +0000 (+2000)
Subject: Re: [Patch v5 4/8] lib: add "verbose" versions of notmuch_database_{open,create}
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=d69296d26e34d84d8e9970db6a2c56b70a046dfa;p=notmuch-archives.git

Re: [Patch v5 4/8] lib: add "verbose" versions of notmuch_database_{open,create}
---

diff --git a/a7/94715d68fa496951bacc5711094e9f8460ba53 b/a7/94715d68fa496951bacc5711094e9f8460ba53
new file mode 100644
index 000000000..d17188d68
--- /dev/null
+++ b/a7/94715d68fa496951bacc5711094e9f8460ba53
@@ -0,0 +1,79 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id F0DAE431FDE
+	for <notmuch@notmuchmail.org>; Wed, 25 Mar 2015 09:48:20 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 2.438
+X-Spam-Level: **
+X-Spam-Status: No, score=2.438 tagged_above=-999 required=5
+	tests=[DNS_FROM_AHBL_RHSBL=2.438] autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id ASEK+0ywZvc9 for <notmuch@notmuchmail.org>;
+	Wed, 25 Mar 2015 09:48:18 -0700 (PDT)
+Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net
+	[87.98.215.224])
+	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id 6A0B5431E62
+	for <notmuch@notmuchmail.org>; Wed, 25 Mar 2015 09:48:17 -0700 (PDT)
+Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim
+	4.80) (envelope-from <david@tethera.net>)
+	id 1YaoSc-0005jp-CB; Wed, 25 Mar 2015 16:47:18 +0000
+Received: (nullmailer pid 18353 invoked by uid 1000); Wed, 25 Mar 2015
+	16:47:06 -0000
+From: David Bremner <david@tethera.net>
+To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
+Subject: Re: [Patch v5 4/8] lib: add "verbose" versions of
+	notmuch_database_{open,create}
+In-Reply-To: <m2bnjhuj43.fsf@guru.guru-group.fi>
+References: <1426352554-4383-10-git-send-email-david@tethera.net>
+	<1427203451-1540-1-git-send-email-david@tethera.net>
+	<1427203451-1540-5-git-send-email-david@tethera.net>
+	<m2bnjhuj43.fsf@guru.guru-group.fi>
+User-Agent: Notmuch/0.19+86~gbed8b67 (http://notmuchmail.org) Emacs/24.4.1
+	(x86_64-pc-linux-gnu)
+Date: Wed, 25 Mar 2015 12:47:06 -0400
+Message-ID: <87a8z1owhh.fsf@maritornes.cs.unb.ca>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Wed, 25 Mar 2015 16:48:21 -0000
+
+Tomi Ollila <tomi.ollila@iki.fi> writes:
+
+>> +    ret = notmuch_database_open_verbose (path,
+>> +					 NOTMUCH_DATABASE_MODE_READ_WRITE,
+>> +					 &notmuch,
+>> +					 &message);
+>>      if (ret) {
+>> +	if (status_cb) status_cb (message, closure);
+>>  	goto DONE;
+>>      }
+>
+> Is this ever printing the message (if any?)
+
+Printing messages is the whole point of status_cb. It does switch the
+output from the current stderr to stdout, which is weird.  On the other
+hand it avoids changing the api by adding
+notmuch_database_compact_verbose.
+
+And of course if we care this should free message after calling
+status_cb, like the other places.
+
+d
+