From: Tomi Ollila Date: Thu, 22 Aug 2013 17:08:46 +0000 (+0300) Subject: Re: [PATCH] Switch to DEF from INITIAL-INPUT in completing-read. X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=d618dcb6ffcd8a98248e4a0c6229a3f96d716907;p=notmuch-archives.git Re: [PATCH] Switch to DEF from INITIAL-INPUT in completing-read. --- diff --git a/45/60c54722e656eda48f899a95c2ed767e8b9f52 b/45/60c54722e656eda48f899a95c2ed767e8b9f52 new file mode 100644 index 000000000..2878ee30f --- /dev/null +++ b/45/60c54722e656eda48f899a95c2ed767e8b9f52 @@ -0,0 +1,140 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 33885431FC4 + for ; Thu, 22 Aug 2013 10:09:03 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id RC5K-vbfAQAv for ; + Thu, 22 Aug 2013 10:08:54 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 93C96431FC2 + for ; Thu, 22 Aug 2013 10:08:54 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id E4B50100086; + Thu, 22 Aug 2013 20:08:46 +0300 (EEST) +From: Tomi Ollila +To: Christopher Wellons , notmuch@notmuchmail.org +Subject: Re: [PATCH] Switch to DEF from INITIAL-INPUT in completing-read. +In-Reply-To: +References: <1377103488-7425-1-git-send-email-wellons@nullprogram.com> + +User-Agent: Notmuch/0.16+3~g340c058 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 22 Aug 2013 17:09:03 -0000 + +On Wed, Aug 21 2013, Tomi Ollila wrote: + +> On Wed, Aug 21 2013, Christopher Wellons wrote: +> +>> As stated in the Emacs documentation, the initial-input argument is +>> deprecated because it presents a poor interface to the user. In fact, +>> with my setup where ido replaces completing-read, it's nearly unusable +>> with initial-input. +>> +>> http://www.gnu.org/software/emacs/manual/html_node/elisp/Initial-Input.html +>> --- +> +> I agree that this behaves better, but the empty content with completing-read +> looks a bit confusing (if arrow keys or tab aren't pressed) +> +> Although the completing-read documentation also deprecates (STRING . POSITION) +> format IMO I found that to work best there: i.e. +> +> - prompt collection nil nil initial-input 'notmuch-address-history)) +> + prompt collection nil nil (cons initial-input 0) 'notmuch-address-history)) + +Actually, I don't know this anymore. Yesterday the current worked a bit +badly but today while I was testing something else the current worked ok... + +... but you're right, with ido-completing-read the current is unusable: + +(load-library "ido") +(ido-completing-read "foo" '("foo" "bar" "baz") nil nil "foo") + +and especially + +(ido-completing-read "foo" '("foo" "bar" "baz") nil nil '("foo" . 0)) + +and, + +(ido-completing-read "foo" '("foo" "bar" "baz") nil nil nil nil "foo") + +surely works the best of the above... + +we could also drop the default/initial input: + +(ido-completing-read "foo" '("foo" "bar" "baz")) +(completing-read "foo" '("foo" "bar" "baz")) + +So that, with completing-read, user presses enter on empty content, +empty string is returned... and doesn't affect how ido-completing-read +does it... + +> +> I don't know how ido-replaced completing-read (just ido-completing-read ?) +> works there, though. +> +> Better get other thoughts/opinions too -- I use this: +> +> https://github.com/domo141/nottoomuch/blob/dogfood/selection-menu.rst +> +> for choosing completions -- it ignores INITIAL-INPUT (/DEF) argument +> altogether. +> +> Tomi + +Tomi + +> +> +>> emacs/notmuch-address.el | 6 +++--- +>> 1 file changed, 3 insertions(+), 3 deletions(-) +>> +>> diff --git a/emacs/notmuch-address.el b/emacs/notmuch-address.el +>> index fa65cd5..e89200b 100644 +>> --- a/emacs/notmuch-address.el +>> +++ b/emacs/notmuch-address.el +>> @@ -42,11 +42,11 @@ to know how address selection is made by default." +>> :group 'notmuch-send +>> :group 'notmuch-external) +>> +>> -(defun notmuch-address-selection-function (prompt collection initial-input) +>> +(defun notmuch-address-selection-function (prompt collection def) +>> "Call (`completing-read' +>> - PROMPT COLLECTION nil nil INITIAL-INPUT 'notmuch-address-history)" +>> + PROMPT COLLECTION nil nil nil 'notmuch-address-history DEF)" +>> (completing-read +>> - prompt collection nil nil initial-input 'notmuch-address-history)) +>> + prompt collection nil nil nil 'notmuch-address-history def)) +>> +>> (defvar notmuch-address-message-alist-member +>> '("^\\(Resent-\\)?\\(To\\|B?Cc\\|Reply-To\\|From\\|Mail-Followup-To\\|Mail-Copies-To\\):" +>> -- +>> 1.8.4.rc3