From: Keith Packard Date: Tue, 17 Nov 2009 21:15:25 +0000 (+1600) Subject: Re: [notmuch] [PATCH 1/2] Close message file after parsing message headers X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=d5f7383a4e5c60fca6cfd8ace303cf1b8daf38e6;p=notmuch-archives.git Re: [notmuch] [PATCH 1/2] Close message file after parsing message headers --- diff --git a/21/a3bc613be5f8009a5d9e3d1dc14b4917cf4106 b/21/a3bc613be5f8009a5d9e3d1dc14b4917cf4106 new file mode 100644 index 000000000..d30ae7eb7 --- /dev/null +++ b/21/a3bc613be5f8009a5d9e3d1dc14b4917cf4106 @@ -0,0 +1,68 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id F1E1A431FAE + for ; Tue, 17 Nov 2009 13:15:30 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id iCUsOU61POSG for ; + Tue, 17 Nov 2009 13:15:29 -0800 (PST) +Received: from keithp.com (home.keithp.com [63.227.221.253]) + by olra.theworths.org (Postfix) with ESMTP id 77B24431FBF + for ; Tue, 17 Nov 2009 13:15:29 -0800 (PST) +Received: from localhost (localhost [127.0.0.1]) + by keithp.com (Postfix) with ESMTP id 95C46760129; + Tue, 17 Nov 2009 13:15:28 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at keithp.com +Received: from keithp.com ([127.0.0.1]) + by localhost (keithp.com [127.0.0.1]) (amavisd-new, port 10024) + with LMTP id zJkWoUraovYM; Tue, 17 Nov 2009 13:15:25 -0800 (PST) +Received: by keithp.com (Postfix, from userid 1033) + id 723E276012A; Tue, 17 Nov 2009 13:15:25 -0800 (PST) +Received: from keithp.com (localhost [127.0.0.1]) + by keithp.com (Postfix) with ESMTP id 64A17760129; + Tue, 17 Nov 2009 13:15:25 -0800 (PST) +From: Keith Packard +To: Carl Worth , Mikhail Gusarov + , notmuch@notmuchmail.org +In-Reply-To: <87lji5cbwo.fsf@yoom.home.cworth.org> +References: <1258471718-6781-1-git-send-email-dottedmag@dottedmag.net> + <87lji5cbwo.fsf@yoom.home.cworth.org> +Date: Tue, 17 Nov 2009 13:15:25 -0800 +Message-ID: +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Subject: Re: [notmuch] [PATCH 1/2] Close message file after parsing message + headers +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.12 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 17 Nov 2009 21:15:31 -0000 + +On Tue, 17 Nov 2009 09:13:27 -0800, Carl Worth wrote: + +> I didn't apply Keith's fix yet, because I think I'd rather just fix the +> indexer to store the In-Reply-To header in a separate term prefix from +> the term used for the References header[*]. That will then let us lookup +> the in-reply-to value later for thread constructions without having to +> open the original email file at all. + +Threading the message also involves displaying the from and to contents, +which requires opening the message file. The alternative to the fix I +provided is to just parse all of the message headers when first opening +the message; it could then be immediately closed and the hash referred +to for all header data. Given the choice, just having the caller say +when it has finished with a message is probably a reasonable option... + +-keith