From: David Bremner <david@tethera.net>
Date: Mon, 25 Apr 2016 19:40:07 +0000 (+2100)
Subject: RE: notmuch-0.21 bug report
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=d56671bc8fd009f709645f1494466ee23e5b78de;p=notmuch-archives.git

RE: notmuch-0.21 bug report
---

diff --git a/79/dbfcc258d0dcb7bd3deadbfd87f91441bde3d7 b/79/dbfcc258d0dcb7bd3deadbfd87f91441bde3d7
new file mode 100644
index 000000000..ec8afc264
--- /dev/null
+++ b/79/dbfcc258d0dcb7bd3deadbfd87f91441bde3d7
@@ -0,0 +1,75 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+ by arlo.cworth.org (Postfix) with ESMTP id 26E626DE00C9
+ for <notmuch@notmuchmail.org>; Mon, 25 Apr 2016 12:40:18 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at cworth.org
+X-Spam-Flag: NO
+X-Spam-Score: -0.016
+X-Spam-Level: 
+X-Spam-Status: No, score=-0.016 tagged_above=-999 required=5
+ tests=[AWL=-0.005, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01]
+ autolearn=disabled
+Received: from arlo.cworth.org ([127.0.0.1])
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
+ with ESMTP id kWqQcrXqOwEo for <notmuch@notmuchmail.org>;
+ Mon, 25 Apr 2016 12:40:10 -0700 (PDT)
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])
+ by arlo.cworth.org (Postfix) with ESMTPS id 5A6106DE00DF
+ for <notmuch@notmuchmail.org>; Mon, 25 Apr 2016 12:40:09 -0700 (PDT)
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84)
+ (envelope-from <david@tethera.net>)
+ id 1aumMi-0002nX-8I; Mon, 25 Apr 2016 15:40:16 -0400
+Received: (nullmailer pid 6093 invoked by uid 1000);
+ Mon, 25 Apr 2016 19:40:07 -0000
+From: David Bremner <david@tethera.net>
+To: David Binderman <dcb314@hotmail.com>,
+ "notmuch@notmuchmail.org" <notmuch@notmuchmail.org>
+Subject: RE: notmuch-0.21 bug report
+In-Reply-To: <DUB128-W40FF39685EC08E151E7E5B9C620@phx.gbl>
+References: <DUB128-W37A050CCA0515311F04F009C620@phx.gbl>
+ <87wpnlbllb.fsf@zancas.localnet>
+ <DUB128-W40FF39685EC08E151E7E5B9C620@phx.gbl>
+User-Agent: Notmuch/0.21+99~gd93d377 (http://notmuchmail.org) Emacs/24.5.1
+ (x86_64-pc-linux-gnu)
+Date: Mon, 25 Apr 2016 16:40:07 -0300
+Message-ID: <87shy9bhpk.fsf@zancas.localnet>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.20
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+ <notmuch.notmuchmail.org>
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Mon, 25 Apr 2016 19:40:18 -0000
+
+David Binderman <dcb314@hotmail.com> writes:
+
+> Hello there,
+>
+> ----------------------------------------
+>> Hi David;
+>>
+>> Thanks for the report. fclose doesn't really make sense here; 
+>
+> Surprising. There is a call to fclose for the success return,
+> so I just assumed that one would also be required for the error return.
+>
+
+Ah OK, I thought the fclose referred to the notmuch database, but it
+refers to the input file. So yes, there is techically a resource leakage
+here, but I'm not sure how important it is, since these returns are part
+of program shutdown. Is there any harm in having FILEs open for read
+when a program shuts down? On the other hand, I guess it would only take
+5 or 6 added lines of code if someone wanted to add our usual "goto
+DONE" path
+
+d