From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
Date: Thu, 7 Oct 2010 04:06:11 +0000 (-0400)
Subject: more tweaks to marginal UI behavior
X-Git-Tag: msva-perl/0.4~2
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=d43f2a5c564855d5177f877c467bbb2f29dacc51;p=monkeysphere-validation-agent.git

more tweaks to marginal UI behavior
---

diff --git a/Crypt/Monkeysphere/MSVA/MarginalUI.pm b/Crypt/Monkeysphere/MSVA/MarginalUI.pm
index 2f0e3cf..a57a71d 100755
--- a/Crypt/Monkeysphere/MSVA/MarginalUI.pm
+++ b/Crypt/Monkeysphere/MSVA/MarginalUI.pm
@@ -156,17 +156,22 @@ GnuPG calculated validity: %s",
     # make the text in the dialog box selectable
     $label->set('selectable', 1);
     $label->show();
-    my $button = Gtk2::Button->new_from_stock('gtk-properties');
+    my $button = Gtk2::Button->new_with_label($peer);
     $button->show();
+    my $tipshowing = 0;
     $button->signal_connect('clicked',
                             sub {
-                              $button->hide();
  # FIXME: for some reason, $label->set_text($labeltxt."\n\n".$tip) throws this error:
  # Insecure dependency in eval_sv() while running with -T switch at Crypt/Monkeysphere/MSVA/MarginalUI.pm line 180.
  # the workaround here (remove, destroy, re-create) seems to work, though.
                               $dialog->get_content_area()->remove($label);
                               $label->destroy();
-                              $label = Gtk2::Label->new($labeltxt."\n\n".$tip);
+                              if ($tipshowing) {
+                                $label = Gtk2::Label->new($labeltxt);
+                              } else {
+                                $label = Gtk2::Label->new($tip."\n\n".$labeltxt);
+                              }
+                              $tipshowing = ! $tipshowing;
                               $label->set('selectable', 1);
                               $label->show();
                               $dialog->get_content_area()->add($label);
@@ -174,8 +179,8 @@ GnuPG calculated validity: %s",
 
     my $tooltips = Gtk2::Tooltips->new();
     $tooltips->set_tip($label, $tip);
-    $dialog->get_content_area()->add($label);
     $dialog->get_content_area()->add($button);
+    $dialog->get_content_area()->add($label);
     my $resp = 0;
 
     my $icon_file = '/usr/share/pixmaps/monkeysphere-icon.png';