From: David Bremner <david@tethera.net>
Date: Tue, 28 Oct 2014 18:43:49 +0000 (+0100)
Subject: Re: [PATCH] test: add simple tests for post-insert hook
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=d38e944fa8cf23f88c7fda49ca9c613b8f6b3f90;p=notmuch-archives.git

Re: [PATCH] test: add simple tests for post-insert hook
---

diff --git a/e4/e30885f2d8ad81bfa00cc04f415d99d83dfc00 b/e4/e30885f2d8ad81bfa00cc04f415d99d83dfc00
new file mode 100644
index 000000000..caca11fc5
--- /dev/null
+++ b/e4/e30885f2d8ad81bfa00cc04f415d99d83dfc00
@@ -0,0 +1,75 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 25758431FB6
+	for <notmuch@notmuchmail.org>; Tue, 28 Oct 2014 11:44:04 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id txrW-GQLhwxo for <notmuch@notmuchmail.org>;
+	Tue, 28 Oct 2014 11:43:56 -0700 (PDT)
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
+	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id 292A9431FBF
+	for <notmuch@notmuchmail.org>; Tue, 28 Oct 2014 11:43:55 -0700 (PDT)
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
+	(envelope-from <david@tethera.net>)
+	id 1XjBkI-0002yw-RH; Tue, 28 Oct 2014 15:43:54 -0300
+Received: (nullmailer pid 10357 invoked by uid 1000); Tue, 28 Oct 2014
+	18:43:49 -0000
+From: David Bremner <david@tethera.net>
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
+Subject: Re: [PATCH] test: add simple tests for post-insert hook
+In-Reply-To: <87ppdcnlvn.fsf@nikula.org>
+References:
+ <27c7ada91f96deda6e51732e0397bffd2ef2ab42.1411914914.git.jani@nikula.org>
+	<1413616955-27612-1-git-send-email-david@tethera.net>
+	<87ppdcnlvn.fsf@nikula.org>
+User-Agent: Notmuch/0.18.1+131~gdd8373f (http://notmuchmail.org) Emacs/24.4.1
+	(x86_64-pc-linux-gnu)
+Date: Tue, 28 Oct 2014 19:43:49 +0100
+Message-ID: <877fzk2fx6.fsf@maritornes.cs.unb.ca>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Tue, 28 Oct 2014 18:44:04 -0000
+
+Jani Nikula <jani@nikula.org> writes:
+
+>
+> I presume the two lines above...
+>
+>> +notmuch insert < "$gen_msg_filename"
+>> +echo $?
+>
+> ...and this line are leftover debug messages?
+
+Uh, yeah. I should have fixed those a while ago when Tomi pointed them
+out.
+
+>
+> Otherwise LGTM. I guess this could be expanded with a subtest checking
+> that the hook does not get run on errors, and does get run with some
+> errors that are ignored with --keep.
+
+OK, I pushed these tests for now (less the debugging output).
+
+d