From: Zac Medico <zmedico@gentoo.org>
Date: Fri, 11 Apr 2008 19:48:06 +0000 (-0000)
Subject: Make doebuild() bail out early with a PermissionDenied error if there
X-Git-Tag: v2.2_pre6~189
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=d31dfa840ca5219b0f5641503db3178acbfc1c98;p=portage.git

Make doebuild() bail out early with a PermissionDenied error if there
is no write access to $PKGDIR.

svn path=/main/trunk/; revision=9837
---

diff --git a/pym/portage/__init__.py b/pym/portage/__init__.py
index e92669c74..0a240002b 100644
--- a/pym/portage/__init__.py
+++ b/pym/portage/__init__.py
@@ -5006,6 +5006,16 @@ def doebuild(myebuild, mydo, myroot, mysettings, debug=0, listonly=0,
 				actionmap[x]["dep"] = ' '.join(actionmap_deps[x])
 
 		if mydo in actionmap:
+			if mydo == "package":
+				# Make sure the package directory exists before executing
+				# this phase. This can raise PermissionDenied if
+				# the current user doesn't have write access to $PKGDIR.
+				parent_dir = os.path.join(mysettings["PKGDIR"],
+					mysettings["CATEGORY"])
+				portage.util.ensure_dirs(parent_dir)
+				if not os.access(parent_dir, os.W_OK):
+					raise portage.exception.PermissionDenied(
+						"access('%s', os.W_OK)" % parent_dir)
 			retval = spawnebuild(mydo,
 				actionmap, mysettings, debug, logfile=logfile)
 		elif mydo=="qmerge":