From: Zac Medico <zmedico@gentoo.org>
Date: Sun, 31 Aug 2008 08:05:50 +0000 (-0000)
Subject: Check for calls to the deprecated bindnow-flags function. Thanks to Diego
X-Git-Tag: v2.2_rc9~44
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=d26b4a4112854bbbfbd6d5f9edc6e6d0454bb1de;p=portage.git

Check for calls to the deprecated bindnow-flags function. Thanks to Diego
"Flameeyes" Pettenò for the suggestion.

svn path=/main/trunk/; revision=11481
---

diff --git a/pym/repoman/checks.py b/pym/repoman/checks.py
index f7d7ce79d..e5237237f 100644
--- a/pym/repoman/checks.py
+++ b/pym/repoman/checks.py
@@ -274,13 +274,19 @@ class EMakeParallelDisabled(LineCheck):
 	re = re.compile(r'^\s*emake\s*-j\s*1\s')
 	error = errors.EMAKE_PARALLEL_DISABLED
 
+class DeprecatedBindnowFlags(LineCheck):
+	"""Check for calls to the deprecated bindnow-flags function."""
+	repoman_check_name = 'ebuild.minorsyn'
+	re = re.compile(r'.*\$\(bindnow-flags\)')
+	error = errors.DEPRECATED_BINDNOW_FLAGS
+
 _constant_checks = tuple((c() for c in (
 	EbuildHeader, EbuildWhitespace, EbuildQuote,
 	EbuildAssignment, EbuildUselessDodoc,
 	EbuildUselessCdS, EbuildNestedDie,
 	EbuildPatches, EbuildQuotedA,
 	IUseUndefined, InheritAutotools,
-	EMakeParallelDisabled)))
+	EMakeParallelDisabled, DeprecatedBindnowFlags)))
 
 def run_checks(contents, pkg):
 	checks = _constant_checks
diff --git a/pym/repoman/errors.py b/pym/repoman/errors.py
index c6577f945..7c54cc13d 100644
--- a/pym/repoman/errors.py
+++ b/pym/repoman/errors.py
@@ -14,3 +14,4 @@ NESTED_DIE_ERROR = 'Ebuild calls die in a subshell on line: %d'
 PATCHES_ERROR = 'PATCHES is not a bash array on line: %d'
 REDUNDANT_CD_S_ERROR = 'Ebuild has redundant cd ${S} statement on line: %d'
 EMAKE_PARALLEL_DISABLED = 'Ebuild calls emake -j1 on line: %d'
+DEPRECATED_BINDNOW_FLAGS = 'Deprecated bindnow-flags call on line: %d'